Xinqi Bao's Git

projects / dmenu.git / blobdiff
summary | log | commit | diff | tree
raw | inline | side by side
free all allocated items, use %zu for size_t
[dmenu.git] / drw.c
diff --git a/drw.c b/drw.c
index a98083e..a50c9ee 100644 (file)
--- a/drw.c
+++ b/drw.c
@@ -63,9 +63,8 @@ utf8decode(const char *c, long *u, size_t clen)
 Drw *
 drw_create(Display *dpy, int screen, Window root, unsigned int w, unsigned int h)
 {
 Drw *
 drw_create(Display *dpy, int screen, Window root, unsigned int w, unsigned int h)
 {
-       Drw *drw;
+       Drw *drw = ecalloc(1, sizeof(Drw));
 
 
-       drw = ecalloc(1, sizeof(Drw));
        drw->dpy = dpy;
        drw->screen = screen;
        drw->root = root;
        drw->dpy = dpy;
        drw->screen = screen;
        drw->root = root;
@@ -73,7 +72,6 @@ drw_create(Display *dpy, int screen, Window root, unsigned int w, unsigned int h
        drw->h = h;
        drw->drawable = XCreatePixmap(dpy, root, w, h, DefaultDepth(dpy, screen));
        drw->gc = XCreateGC(dpy, root, 0, NULL);
        drw->h = h;
        drw->drawable = XCreatePixmap(dpy, root, w, h, DefaultDepth(dpy, screen));
        drw->gc = XCreateGC(dpy, root, 0, NULL);
-       drw->fontcount = 0;
        XSetLineAttributes(dpy, drw->gc, 1, LineSolid, CapButt, JoinMiter);
 
        return drw;
        XSetLineAttributes(dpy, drw->gc, 1, LineSolid, CapButt, JoinMiter);
 
        return drw;
@@ -84,6 +82,7 @@ drw_resize(Drw *drw, unsigned int w, unsigned int h)
 {
        if (!drw)
                return;
 {
        if (!drw)
                return;
+
        drw->w = w;
        drw->h = h;
        if (drw->drawable)
        drw->w = w;
        drw->h = h;
        if (drw->drawable)
@@ -94,252 +93,280 @@ drw_resize(Drw *drw, unsigned int w, unsigned int h)
 void
 drw_free(Drw *drw)
 {
 void
 drw_free(Drw *drw)
 {
-       size_t i;
-
-       for (i = 0; i < drw->fontcount; i++)
-               drw_font_free(drw->fonts[i]);
        XFreePixmap(drw->dpy, drw->drawable);
        XFreeGC(drw->dpy, drw->gc);
        XFreePixmap(drw->dpy, drw->drawable);
        XFreeGC(drw->dpy, drw->gc);
+       drw_fontset_free(drw->fonts);
        free(drw);
 }
 
 /* This function is an implementation detail. Library users should use
        free(drw);
 }
 
 /* This function is an implementation detail. Library users should use
- * drw_font_create instead.
+ * drw_fontset_create instead.
  */
 static Fnt *
  */
 static Fnt *
-drw_font_xcreate(Drw *drw, const char *fontname, FcPattern *fontpattern)
+xfont_create(Drw *drw, const char *fontname, FcPattern *fontpattern)
 {
        Fnt *font;
 {
        Fnt *font;
-
-       if (!(fontname || fontpattern))
-               die("No font specified.\n");
-
-       if (!(font = calloc(1, sizeof(Fnt))))
-               return NULL;
+       XftFont *xfont = NULL;
+       FcPattern *pattern = NULL;
 
        if (fontname) {
 
        if (fontname) {
-               /* Using the pattern found at font->xfont->pattern does not yield same
-                * the same substitution results as using the pattern returned by
+               /* Using the pattern found at font->xfont->pattern does not yield the
+                * same substitution results as using the pattern returned by
                 * FcNameParse; using the latter results in the desired fallback
                 * FcNameParse; using the latter results in the desired fallback
-                * behaviour whereas the former just results in
-                * missing-character-rectangles being drawn, at least with some fonts.
-                */
-               if (!(font->xfont = XftFontOpenName(drw->dpy, drw->screen, fontname)) ||
-                   !(font->pattern = FcNameParse((FcChar8 *) fontname))) {
-                       if (font->xfont) {
-                               XftFontClose(drw->dpy, font->xfont);
-                               font->xfont = NULL;
-                       }
-                       fprintf(stderr, "error, cannot load font: '%s'\n", fontname);
+                * behaviour whereas the former just results in missing-character
+                * rectangles being drawn, at least with some fonts. */
+               if (!(xfont = XftFontOpenName(drw->dpy, drw->screen, fontname))) {
+                       fprintf(stderr, "error, cannot load font from name: '%s'\n", fontname);
+                       return NULL;
+               }
+               if (!(pattern = FcNameParse((FcChar8 *) fontname))) {
+                       fprintf(stderr, "error, cannot parse font name to pattern: '%s'\n", fontname);
+                       XftFontClose(drw->dpy, xfont);
+                       return NULL;
                }
        } else if (fontpattern) {
                }
        } else if (fontpattern) {
-               if (!(font->xfont = XftFontOpenPattern(drw->dpy, fontpattern)))
-                       fprintf(stderr, "error, cannot load font pattern.\n");
-               else
-                       font->pattern = NULL;
+               if (!(xfont = XftFontOpenPattern(drw->dpy, fontpattern))) {
+                       fprintf(stderr, "error, cannot load font from pattern.\n");
+                       return NULL;
+               }
+       } else {
+               die("no font specified.");
        }
 
        }
 
-       if (!font->xfont) {
-               free(font);
+       /* Do not allow using color fonts. This is a workaround for a BadLength
+        * error from Xft with color glyphs. Modelled on the Xterm workaround. See
+        * https://bugzilla.redhat.com/show_bug.cgi?id=1498269
+        * https://lists.suckless.org/dev/1701/30932.html
+        * https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916349
+        * and lots more all over the internet.
+        */
+       FcBool iscol;
+       if(FcPatternGetBool(xfont->pattern, FC_COLOR, 0, &iscol) == FcResultMatch && iscol) {
+               XftFontClose(drw->dpy, xfont);
                return NULL;
        }
 
                return NULL;
        }
 
-       font->ascent = font->xfont->ascent;
-       font->descent = font->xfont->descent;
-       font->h = font->ascent + font->descent;
+       font = ecalloc(1, sizeof(Fnt));
+       font->xfont = xfont;
+       font->pattern = pattern;
+       font->h = xfont->ascent + xfont->descent;
        font->dpy = drw->dpy;
 
        return font;
 }
 
        font->dpy = drw->dpy;
 
        return font;
 }
 
-Fnt*
-drw_font_create(Drw *drw, const char *fontname)
+static void
+xfont_free(Fnt *font)
 {
 {
-       return drw_font_xcreate(drw, fontname, NULL);
+       if (!font)
+               return;
+       if (font->pattern)
+               FcPatternDestroy(font->pattern);
+       XftFontClose(font->dpy, font->xfont);
+       free(font);
 }
 
 }
 
-void
-drw_load_fonts(Drw* drw, const char *fonts[], size_t fontcount)
+Fnt*
+drw_fontset_create(Drw* drw, const char *fonts[], size_t fontcount)
 {
 {
+       Fnt *cur, *ret = NULL;
        size_t i;
        size_t i;
-       Fnt *font;
 
 
-       for (i = 0; i < fontcount; i++) {
-               if (drw->fontcount >= DRW_FONT_CACHE_SIZE) {
-                       die("Font cache exhausted.\n");
-               } else if ((font = drw_font_xcreate(drw, fonts[i], NULL))) {
-                       drw->fonts[drw->fontcount++] = font;
+       if (!drw || !fonts)
+               return NULL;
+
+       for (i = 1; i <= fontcount; i++) {
+               if ((cur = xfont_create(drw, fonts[fontcount - i], NULL))) {
+                       cur->next = ret;
+                       ret = cur;
                }
        }
                }
        }
+       return (drw->fonts = ret);
 }
 
 void
 }
 
 void
-drw_font_free(Fnt *font)
+drw_fontset_free(Fnt *font)
 {
 {
-       if (!font)
-               return;
-       if (font->pattern)
-               FcPatternDestroy(font->pattern);
-       XftFontClose(font->dpy, font->xfont);
-       free(font);
+       if (font) {
+               drw_fontset_free(font->next);
+               xfont_free(font);
+       }
 }
 
 }
 
-Clr *
-drw_clr_create(Drw *drw, const char *clrname)
+void
+drw_clr_create(Drw *drw, Clr *dest, const char *clrname)
 {
 {
-       Clr *clr;
-       if (!drw)
-               return NULL;
+       if (!drw || !dest || !clrname)
+               return;
 
 
-       clr = ecalloc(1, sizeof(Clr));
        if (!XftColorAllocName(drw->dpy, DefaultVisual(drw->dpy, drw->screen),
                               DefaultColormap(drw->dpy, drw->screen),
        if (!XftColorAllocName(drw->dpy, DefaultVisual(drw->dpy, drw->screen),
                               DefaultColormap(drw->dpy, drw->screen),
-                              clrname, &clr->rgb))
-               die("error, cannot allocate color '%s'\n", clrname);
-       clr->pix = clr->rgb.pixel;
+                              clrname, dest))
+               die("error, cannot allocate color '%s'", clrname);
+}
+
+/* Wrapper to create color schemes. The caller has to call free(3) on the
+ * returned color scheme when done using it. */
+Clr *
+drw_scm_create(Drw *drw, const char *clrnames[], size_t clrcount)
+{
+       size_t i;
+       Clr *ret;
 
 
-       return clr;
+       /* need at least two colors for a scheme */
+       if (!drw || !clrnames || clrcount < 2 || !(ret = ecalloc(clrcount, sizeof(XftColor))))
+               return NULL;
+
+       for (i = 0; i < clrcount; i++)
+               drw_clr_create(drw, &ret[i], clrnames[i]);
+       return ret;
 }
 
 void
 }
 
 void
-drw_clr_free(Clr *clr)
+drw_setfontset(Drw *drw, Fnt *set)
 {
 {
-       free(clr);
+       if (drw)
+               drw->fonts = set;
 }
 
 void
 }
 
 void
-drw_setscheme(Drw *drw, ClrScheme *scheme)
+drw_setscheme(Drw *drw, Clr *scm)
 {
 {
-       if (!drw)
-               return;
-       drw->scheme = scheme;
+       if (drw)
+               drw->scheme = scm;
 }
 
 void
 }
 
 void
-drw_rect(Drw *drw, int x, int y, unsigned int w, unsigned int h, int filled, int empty, int invert)
+drw_rect(Drw *drw, int x, int y, unsigned int w, unsigned int h, int filled, int invert)
 {
        if (!drw || !drw->scheme)
                return;
 {
        if (!drw || !drw->scheme)
                return;
-       XSetForeground(drw->dpy, drw->gc, invert ? drw->scheme->bg->pix : drw->scheme->fg->pix);
+       XSetForeground(drw->dpy, drw->gc, invert ? drw->scheme[ColBg].pixel : drw->scheme[ColFg].pixel);
        if (filled)
        if (filled)
-               XFillRectangle(drw->dpy, drw->drawable, drw->gc, x, y, w + 1, h + 1);
-       else if (empty)
-               XDrawRectangle(drw->dpy, drw->drawable, drw->gc, x, y, w, h);
+               XFillRectangle(drw->dpy, drw->drawable, drw->gc, x, y, w, h);
+       else
+               XDrawRectangle(drw->dpy, drw->drawable, drw->gc, x, y, w - 1, h - 1);
 }
 
 int
 }
 
 int
-drw_text(Drw *drw, int x, int y, unsigned int w, unsigned int h, const char *text, int invert)
+drw_text(Drw *drw, int x, int y, unsigned int w, unsigned int h, unsigned int lpad, const char *text, int invert)
 {
 {
-       char buf[1024];
-       int tx, ty, th;
-       Extnts tex;
-       Colormap cmap;
-       Visual *vis;
-       XftDraw *d;
-       Fnt *curfont, *nextfont;
-       size_t i, len;
-       int utf8strlen, utf8charlen, render;
+       int i, ty, ellipsis_x = 0;
+       unsigned int tmpw, ew, ellipsis_w = 0, ellipsis_len, ellipsis_width;
+       XftDraw *d = NULL;
+       Fnt *usedfont, *curfont, *nextfont;
+       int utf8strlen, utf8charlen, render = x || y || w || h;
        long utf8codepoint = 0;
        const char *utf8str;
        FcCharSet *fccharset;
        FcPattern *fcpattern;
        FcPattern *match;
        XftResult result;
        long utf8codepoint = 0;
        const char *utf8str;
        FcCharSet *fccharset;
        FcPattern *fcpattern;
        FcPattern *match;
        XftResult result;
-       int charexists = 0;
+       int charexists = 0, overflow = 0;
+       /* keep track of a couple codepoints for which we have no match. */
+       enum { nomatches_len = 64 };
+       static struct { long codepoint[nomatches_len]; unsigned int idx; } nomatches;
 
 
-       if (!(render = x || y || w || h))
-               w = ~w;
-
-       if (!drw || !drw->scheme) {
+       if (!drw || (render && !drw->scheme) || !text || !drw->fonts)
                return 0;
                return 0;
-       } else if (render) {
-               XSetForeground(drw->dpy, drw->gc, invert ? drw->scheme->fg->pix : drw->scheme->bg->pix);
-               XFillRectangle(drw->dpy, drw->drawable, drw->gc, x, y, w, h);
-       }
 
 
-       if (!text || !drw->fontcount) {
-               return 0;
-       } else if (render) {
-               cmap = DefaultColormap(drw->dpy, drw->screen);
-               vis = DefaultVisual(drw->dpy, drw->screen);
-               d = XftDrawCreate(drw->dpy, drw->drawable, vis, cmap);
+       if (!render) {
+               w = invert ? invert : ~invert;
+       } else {
+               XSetForeground(drw->dpy, drw->gc, drw->scheme[invert ? ColFg : ColBg].pixel);
+               XFillRectangle(drw->dpy, drw->drawable, drw->gc, x, y, w, h);
+               d = XftDrawCreate(drw->dpy, drw->drawable,
+                                 DefaultVisual(drw->dpy, drw->screen),
+                                 DefaultColormap(drw->dpy, drw->screen));
+               x += lpad;
+               w -= lpad;
        }
 
        }
 
-       curfont = drw->fonts[0];
+       usedfont = drw->fonts;
+       drw_font_getexts(usedfont, "...", 3, &ellipsis_width, NULL);
        while (1) {
        while (1) {
-               utf8strlen = 0;
+               ew = ellipsis_len = utf8strlen = 0;
                utf8str = text;
                nextfont = NULL;
                while (*text) {
                        utf8charlen = utf8decode(text, &utf8codepoint, UTF_SIZ);
                utf8str = text;
                nextfont = NULL;
                while (*text) {
                        utf8charlen = utf8decode(text, &utf8codepoint, UTF_SIZ);
-                       for (i = 0; i < drw->fontcount; i++) {
-                               charexists = charexists || XftCharExists(drw->dpy, drw->fonts[i]->xfont, utf8codepoint);
+                       for (curfont = drw->fonts; curfont; curfont = curfont->next) {
+                               charexists = charexists || XftCharExists(drw->dpy, curfont->xfont, utf8codepoint);
                                if (charexists) {
                                if (charexists) {
-                                       if (drw->fonts[i] == curfont) {
+                                       drw_font_getexts(curfont, text, utf8charlen, &tmpw, NULL);
+                                       if (ew + ellipsis_width <= w) {
+                                               /* keep track where the ellipsis still fits */
+                                               ellipsis_x = x + ew;
+                                               ellipsis_w = w - ew;
+                                               ellipsis_len = utf8strlen;
+                                       }
+
+                                       if (ew + tmpw > w) {
+                                               overflow = 1;
+                                               /* called from drw_fontset_getwidth_clamp():
+                                                * it wants the width AFTER the overflow
+                                                */
+                                               if (!render)
+                                                       x += tmpw;
+                                               else
+                                                       utf8strlen = ellipsis_len;
+                                       } else if (curfont == usedfont) {
                                                utf8strlen += utf8charlen;
                                                text += utf8charlen;
                                                utf8strlen += utf8charlen;
                                                text += utf8charlen;
+                                               ew += tmpw;
                                        } else {
                                        } else {
-                                               nextfont = drw->fonts[i];
+                                               nextfont = curfont;
                                        }
                                        break;
                                }
                        }
 
                                        }
                                        break;
                                }
                        }
 
-                       if (!charexists || (nextfont && nextfont != curfont))
+                       if (overflow || !charexists || nextfont)
                                break;
                        else
                                charexists = 0;
                }
 
                if (utf8strlen) {
                                break;
                        else
                                charexists = 0;
                }
 
                if (utf8strlen) {
-                       drw_font_getexts(curfont, utf8str, utf8strlen, &tex);
-                       /* shorten text if necessary */
-                       for (len = MIN(utf8strlen, (sizeof buf) - 1); len && (tex.w > w - drw->fonts[0]->h || w < drw->fonts[0]->h); len--)
-                               drw_font_getexts(curfont, utf8str, len, &tex);
-
-                       if (len) {
-                               memcpy(buf, utf8str, len);
-                               buf[len] = '\0';
-                               if (len < utf8strlen)
-                                       for (i = len; i && i > len - 3; buf[--i] = '.');
-
-                               if (render) {
-                                       th = curfont->ascent + curfont->descent;
-                                       ty = y + (h / 2) - (th / 2) + curfont->ascent;
-                                       tx = x + (h / 2);
-                                       XftDrawStringUtf8(d, invert ? &drw->scheme->bg->rgb : &drw->scheme->fg->rgb, curfont->xfont, tx, ty, (XftChar8 *)buf, len);
-                               }
-                               x += tex.w;
-                               w -= tex.w;
+                       if (render) {
+                               ty = y + (h - usedfont->h) / 2 + usedfont->xfont->ascent;
+                               XftDrawStringUtf8(d, &drw->scheme[invert ? ColBg : ColFg],
+                                                 usedfont->xfont, x, ty, (XftChar8 *)utf8str, utf8strlen);
                        }
                        }
+                       x += ew;
+                       w -= ew;
                }
                }
+               if (render && overflow)
+                       drw_text(drw, ellipsis_x, y, ellipsis_w, h, 0, "...", invert);
 
 
-               if (!*text) {
+               if (!*text || overflow) {
                        break;
                } else if (nextfont) {
                        charexists = 0;
                        break;
                } else if (nextfont) {
                        charexists = 0;
-                       curfont = nextfont;
+                       usedfont = nextfont;
                } else {
                        /* Regardless of whether or not a fallback font is found, the
                } else {
                        /* Regardless of whether or not a fallback font is found, the
-                        * character must be drawn.
-                        */
+                        * character must be drawn. */
                        charexists = 1;
 
                        charexists = 1;
 
-                       if (drw->fontcount >= DRW_FONT_CACHE_SIZE)
-                               continue;
+                       for (i = 0; i < nomatches_len; ++i) {
+                               /* avoid calling XftFontMatch if we know we won't find a match */
+                               if (utf8codepoint == nomatches.codepoint[i])
+                                       goto no_match;
+                       }
 
                        fccharset = FcCharSetCreate();
                        FcCharSetAddChar(fccharset, utf8codepoint);
 
 
                        fccharset = FcCharSetCreate();
                        FcCharSetAddChar(fccharset, utf8codepoint);
 
-                       if (!drw->fonts[0]->pattern) {
-                               /* Refer to the comment in drw_font_xcreate for more
-                                * information. */
-                               die("The first font in the cache must be loaded from a font string.\n");
+                       if (!drw->fonts->pattern) {
+                               /* Refer to the comment in xfont_create for more information. */
+                               die("the first font in the cache must be loaded from a font string.");
                        }
 
                        }
 
-                       fcpattern = FcPatternDuplicate(drw->fonts[0]->pattern);
+                       fcpattern = FcPatternDuplicate(drw->fonts->pattern);
                        FcPatternAddCharSet(fcpattern, FC_CHARSET, fccharset);
                        FcPatternAddBool(fcpattern, FC_SCALABLE, FcTrue);
                        FcPatternAddCharSet(fcpattern, FC_CHARSET, fccharset);
                        FcPatternAddBool(fcpattern, FC_SCALABLE, FcTrue);
+                       FcPatternAddBool(fcpattern, FC_COLOR, FcFalse);
 
                        FcConfigSubstitute(NULL, fcpattern, FcMatchPattern);
                        FcDefaultSubstitute(fcpattern);
 
                        FcConfigSubstitute(NULL, fcpattern, FcMatchPattern);
                        FcDefaultSubstitute(fcpattern);
@@ -349,21 +376,24 @@ drw_text(Drw *drw, int x, int y, unsigned int w, unsigned int h, const char *tex
                        FcPatternDestroy(fcpattern);
 
                        if (match) {
                        FcPatternDestroy(fcpattern);
 
                        if (match) {
-                               curfont = drw_font_xcreate(drw, NULL, match);
-                               if (curfont && XftCharExists(drw->dpy, curfont->xfont, utf8codepoint)) {
-                                       drw->fonts[drw->fontcount++] = curfont;
+                               usedfont = xfont_create(drw, NULL, match);
+                               if (usedfont && XftCharExists(drw->dpy, usedfont->xfont, utf8codepoint)) {
+                                       for (curfont = drw->fonts; curfont->next; curfont = curfont->next)
+                                               ; /* NOP */
+                                       curfont->next = usedfont;
                                } else {
                                } else {
-                                       if (curfont)
-                                               drw_font_free(curfont);
-                                       curfont = drw->fonts[0];
+                                       xfont_free(usedfont);
+                                       nomatches.codepoint[++nomatches.idx % nomatches_len] = utf8codepoint;
+no_match:
+                                       usedfont = drw->fonts;
                                }
                        }
                }
        }
                                }
                        }
                }
        }
-       if (render)
+       if (d)
                XftDrawDestroy(d);
 
                XftDrawDestroy(d);
 
-       return x;
+       return x + (render ? w : 0);
 }
 
 void
 }
 
 void
@@ -371,31 +401,41 @@ drw_map(Drw *drw, Window win, int x, int y, unsigned int w, unsigned int h)
 {
        if (!drw)
                return;
 {
        if (!drw)
                return;
+
        XCopyArea(drw->dpy, drw->drawable, win, drw->gc, x, y, w, h, x, y);
        XSync(drw->dpy, False);
 }
 
        XCopyArea(drw->dpy, drw->drawable, win, drw->gc, x, y, w, h, x, y);
        XSync(drw->dpy, False);
 }
 
+unsigned int
+drw_fontset_getwidth(Drw *drw, const char *text)
+{
+       if (!drw || !drw->fonts || !text)
+               return 0;
+       return drw_text(drw, 0, 0, 0, 0, 0, text, 0);
+}
+
+unsigned int
+drw_fontset_getwidth_clamp(Drw *drw, const char *text, unsigned int n)
+{
+       unsigned int tmp = 0;
+       if (drw && drw->fonts && text && n)
+               tmp = drw_text(drw, 0, 0, 0, 0, 0, text, n);
+       return MIN(n, tmp);
+}
+
 void
 void
-drw_font_getexts(Fnt *font, const char *text, unsigned int len, Extnts *tex)
+drw_font_getexts(Fnt *font, const char *text, unsigned int len, unsigned int *w, unsigned int *h)
 {
        XGlyphInfo ext;
 
        if (!font || !text)
                return;
 {
        XGlyphInfo ext;
 
        if (!font || !text)
                return;
-       XftTextExtentsUtf8(font->dpy, font->xfont, (XftChar8 *)text, len, &ext);
-       tex->h = font->h;
-       tex->w = ext.xOff;
-}
 
 
-unsigned int
-drw_font_getexts_width(Fnt *font, const char *text, unsigned int len)
-{
-       Extnts tex;
-
-       if (!font)
-               return -1;
-       drw_font_getexts(font, text, len, &tex);
-       return tex.w;
+       XftTextExtentsUtf8(font->dpy, font->xfont, (XftChar8 *)text, len, &ext);
+       if (w)
+               *w = ext.xOff;
+       if (h)
+               *h = font->h;
 }
 
 Cur *
 }
 
 Cur *
@@ -403,9 +443,9 @@ drw_cur_create(Drw *drw, int shape)
 {
        Cur *cur;
 
 {
        Cur *cur;
 
-       if (!drw)
+       if (!drw || !(cur = ecalloc(1, sizeof(Cur))))
                return NULL;
                return NULL;
-       cur = ecalloc(1, sizeof(Cur));
+
        cur->cursor = XCreateFontCursor(drw->dpy, shape);
 
        return cur;
        cur->cursor = XCreateFontCursor(drw->dpy, shape);
 
        return cur;
@@ -414,8 +454,9 @@ drw_cur_create(Drw *drw, int shape)
 void
 drw_cur_free(Drw *drw, Cur *cursor)
 {
 void
 drw_cur_free(Drw *drw, Cur *cursor)
 {
-       if (!drw || !cursor)
+       if (!cursor)
                return;
                return;
+
        XFreeCursor(drw->dpy, cursor->cursor);
        free(cursor);
 }
        XFreeCursor(drw->dpy, cursor->cursor);
        free(cursor);
 }