adding some prevention that master clients get smaller than bh

[dwm.git] / view.c

diff --git a/view.c b/view.c
index 90080fb..793151d 100644 (file)
--- a/view.c
+++ b/view.c
@@ -1,56 +1,62 @@
-/*
- * (C)opyright MMVI Anselm R. Garbe <garbeam at gmail dot com>
+/* (C)opyright MMVI-MMVII Anselm R. Garbe <garbeam at gmail dot com>

  * See LICENSE file for license details.
  */
 #include "dwm.h"
 
 /* static */
 
  * See LICENSE file for license details.
  */
 #include "dwm.h"
 
 /* static */
 

-static Client *
-minclient(void) {
-       Client *c, *min;
-
-       if((clients && clients->isfloat) || arrange == dofloat)
-               return clients; /* don't touch floating order */
-       for(min = c = clients; c; c = c->next)
-               if(c->weight < min->weight)
-                       min = c;
-       return min;
-}
-

 static Client *
 nexttiled(Client *c) {
        for(c = getnext(c); c && c->isfloat; c = getnext(c->next));
        return c;
 }
 
 static Client *
 nexttiled(Client *c) {
        for(c = getnext(c); c && c->isfloat; c = getnext(c->next));
        return c;
 }
 

+static Bool
+ismaster(Client *c) {
+       Client *cl;
+       unsigned int i;
+
+       for(cl = nexttiled(clients), i = 0; cl && cl != c; cl = nexttiled(cl->next), i++);
+       return i < nmaster;
+}
+

 static void
 static void

-reorder(void) {
-       Client *c, *newclients, *tail;
-
-       newclients = tail = NULL;
-       while((c = minclient())) {
-               detach(c);
-               if(tail) {
-                       c->prev = tail;
-                       tail->next = c;
-                       tail = c;
-               }
-               else
-                       tail = newclients = c;
-       }
-       clients = newclients;
+pop(Client *c) {
+       detach(c);
+       if(clients)
+               clients->prev = c;
+       c->next = clients;
+       clients = c;

 }
 
 static void
 }
 
 static void

-togglemax(Client *c)
-{
+swap(Client *c1, Client *c2) {
+       Client tmp = *c1;
+       Client *cp = c1->prev;
+       Client *cn = c1->next;
+
+       *c1 = *c2;
+       c1->prev = cp;
+       c1->next = cn;
+       cp = c2->prev;
+       cn = c2->next;
+       *c2 = tmp;
+       c2->prev = cp;
+       c2->next = cn;
+}
+
+static void
+togglemax(Client *c) {

        XEvent ev;
        XEvent ev;

+               
+       if(c->isfixed)
+               return;
+

        if((c->ismax = !c->ismax)) {
        if((c->ismax = !c->ismax)) {

-               c->rx = c->x; c->x = sx;
-               c->ry = c->y; c->y = bh;
-               c->rw = c->w; c->w = sw - 2 * BORDERPX;
-               c->rh = c->h; c->h = sh - bh - 2 * BORDERPX;
+               c->rx = c->x; c->x = wax;
+               c->ry = c->y; c->y = way;
+               c->rw = c->w; c->w = waw - 2 * BORDERPX;
+               c->rh = c->h; c->h = wah - 2 * BORDERPX;

        }
        else {
                c->x = c->rx;
        }
        else {
                c->x = c->rx;


@@ -62,11 +68,18 @@ togglemax(Client *c)
        while(XCheckMaskEvent(dpy, EnterWindowMask, &ev));
 }
 
        while(XCheckMaskEvent(dpy, EnterWindowMask, &ev));
 }
 

+static Client *
+topofstack() {
+       Client *c;
+       unsigned int i;
+
+       for(c = nexttiled(clients), i = 0; c && i < nmaster; c = nexttiled(c->next), i++);
+       return (i < nmaster) ? NULL : c;
+}
+

 /* extern */
 
 /* extern */
 

-void (*arrange)(Arg *) = DEFMODE;
-Bool isvertical = VERTICALSTACK;
-StackPos stackpos = STACKPOS;
+void (*arrange)(void) = DEFMODE;

 
 void
 detach(Client *c) {
 
 void
 detach(Client *c) {


@@ -80,7 +93,7 @@ detach(Client *c) {
 }
 
 void
 }
 
 void

-dofloat(Arg *arg) {
+dofloat(void) {

        Client *c;
 
        for(c = clients; c; c = c->next) {
        Client *c;
 
        for(c = clients; c; c = c->next) {


@@ -97,80 +110,49 @@ dofloat(Arg *arg) {
        restack();
 }
 
        restack();
 }
 

-/* This algorithm is based on a (M)aster area and a (S)tacking area.
- * It supports following arrangements:
- *     MMMS            MMMM            SMMM
- *     MMMS            MMMM            SMMM
- *     MMMS            SSSS            SMMM
- */

 void
 void

-dotile(Arg *arg) {
-       int h, i, n, w;
+dotile(void) {
+       unsigned int i, n, mw, mh, tw, th;

        Client *c;
 
        for(n = 0, c = nexttiled(clients); c; c = nexttiled(c->next))
                n++;
        Client *c;
 
        for(n = 0, c = nexttiled(clients); c; c = nexttiled(c->next))
                n++;

+       /* window geoms */
+       mw = (n > nmaster) ? (waw * master) / 1000 : waw;
+       mh = (n > nmaster) ? wah / nmaster : wah / (n > 0 ? n : 1);
+       tw = waw - mw;
+       th = (n > nmaster) ? wah / (n - nmaster) : 0;

 
 

-       if(isvertical) {
-               if(stackpos == StackBottom) {
-                       w = sw;
-                       if(n > 1)
-                               h = (sh - bh) / (n - 1);
-                       else
-                               h = sh - bh;
-               }
-               else {
-                       w = sw - master;
-                       if(n > 1)
-                               h = (sh - bh) / (n - 1);
-                       else
-                               h = sh - bh;
-               }
-       }
-       else { /* horizontal stack */
-
-       }
-
-       for(i = 0, c = clients; c; c = c->next) {
+       for(i = 0, c = clients; c; c = c->next)

                if(isvisible(c)) {
                        if(c->isfloat) {
                                resize(c, True, TopLeft);
                                continue;
                        }
                        c->ismax = False;
                if(isvisible(c)) {
                        if(c->isfloat) {
                                resize(c, True, TopLeft);
                                continue;
                        }
                        c->ismax = False;

-                       if(n == 1) {
-                               c->x = sx;
-                               c->y = sy + bh;
-                               c->w = sw - 2 * BORDERPX;
-                               c->h = sh - 2 * BORDERPX - bh;
-                       }
-                       else if(i == 0) {
-                               c->x = sx;
-                               c->y = sy + bh;
-                               c->w = master - 2 * BORDERPX;
-                               c->h = sh - 2 * BORDERPX - bh;
-                       }
-                       else if(h > bh) {
-                               c->x = sx + master;
-                               c->y = sy + (i - 1) * h + bh;
-                               c->w = w - 2 * BORDERPX;
-                               if(i + 1 == n)
-                                       c->h = sh - c->y - 2 * BORDERPX;
-                               else
-                                       c->h = h - 2 * BORDERPX;
+                       c->x = wax;
+                       c->y = way;
+                       if(i < nmaster) {
+                               c->y += i * mh;
+                               c->w = mw - 2 * BORDERPX;
+                               c->h = mh - 2 * BORDERPX;

                        }
                        }

-                       else { /* fallback if h < bh */
-                               c->x = sx + master;
-                               c->y = sy + bh;
-                               c->w = w - 2 * BORDERPX;
-                               c->h = sh - 2 * BORDERPX - bh;
+                       else {  /* tile window */
+                               c->x += mw;
+                               c->w = tw - 2 * BORDERPX;
+                               if(th > bh) {
+                                       c->y += (i - nmaster) * th;
+                                       c->h = th - 2 * BORDERPX;
+                               }
+                               else /* fallback if th < bh */
+                                       c->h = wah - 2 * BORDERPX;

                        }
                        resize(c, False, TopLeft);
                        i++;
                }
                else
                        ban(c);
                        }
                        resize(c, False, TopLeft);
                        i++;
                }
                else
                        ban(c);

-       }
+

        if(!sel || !isvisible(sel)) {
                for(c = stack; c && !isvisible(c); c = c->snext);
                focus(c);
        if(!sel || !isvisible(sel)) {
                for(c = stack; c && !isvisible(c); c = c->snext);
                focus(c);


@@ -184,7 +166,6 @@ focusnext(Arg *arg) {
    
        if(!sel)
                return;
    
        if(!sel)
                return;

-

        if(!(c = getnext(sel->next)))
                c = getnext(clients);
        if(c) {
        if(!(c = getnext(sel->next)))
                c = getnext(clients);
        if(c) {


@@ -199,7 +180,6 @@ focusprev(Arg *arg) {
 
        if(!sel)
                return;
 
        if(!sel)
                return;

-

        if(!(c = getprev(sel->prev))) {
                for(c = clients; c && c->next; c = c->next);
                c = getprev(c);
        if(!(c = getprev(sel->prev))) {
                for(c = clients; c && c->next; c = c->next);
                c = getprev(c);


@@ -210,6 +190,15 @@ focusprev(Arg *arg) {
        }
 }
 
        }
 }
 

+void
+incnmaster(Arg *arg) {
+       if(nmaster + arg->i < 1 || (wah / (nmaster + arg->i) < bh))
+               return;
+       nmaster += arg->i;
+
+       arrange();
+}
+

 Bool
 isvisible(Client *c) {
        unsigned int i;
 Bool
 isvisible(Client *c) {
        unsigned int i;


@@ -221,27 +210,15 @@ isvisible(Client *c) {
 }
 
 void
 }
 
 void

-resizecol(Arg *arg) {
-       unsigned int n;
-       Client *c;
-
-       for(n = 0, c = clients; c; c = c->next)
-               if(isvisible(c) && !c->isfloat)
-                       n++;
-       if(!sel || sel->isfloat || n < 2 || (arrange == dofloat))
-               return;
-
-       if(sel == getnext(clients)) {
-               if(master + arg->i > sw - 100 || master + arg->i < 100)
-                       return;
-               master += arg->i;
-       }
+resizemaster(Arg *arg) {
+       if(arg->i == 0)
+               master = MASTER;

        else {
        else {

-               if(master - arg->i > sw - 100 || master - arg->i < 100)
+               if(master + arg->i > 950 || master + arg->i < 50)

                        return;
                        return;

-               master -= arg->i;
+               master += arg->i;

        }
        }

-       arrange(NULL);
+       arrange();

 }
 
 void
 }
 
 void


@@ -257,21 +234,36 @@ restack(void) {
                XRaiseWindow(dpy, sel->win);
                XRaiseWindow(dpy, sel->twin);
        }
                XRaiseWindow(dpy, sel->win);
                XRaiseWindow(dpy, sel->twin);
        }

-       if(arrange != dofloat)
+       if(arrange != dofloat) {
+               if(!sel->isfloat) {
+                       XLowerWindow(dpy, sel->twin);
+                       XLowerWindow(dpy, sel->win);
+               }

                for(c = nexttiled(clients); c; c = nexttiled(c->next)) {
                for(c = nexttiled(clients); c; c = nexttiled(c->next)) {

+                       if(c == sel)
+                               continue;

                        XLowerWindow(dpy, c->twin);
                        XLowerWindow(dpy, c->win);
                }
                        XLowerWindow(dpy, c->twin);
                        XLowerWindow(dpy, c->win);
                }

+       }

        drawall();
        XSync(dpy, False);
        while(XCheckMaskEvent(dpy, EnterWindowMask, &ev));
 }
 
        drawall();
        XSync(dpy, False);
        while(XCheckMaskEvent(dpy, EnterWindowMask, &ev));
 }
 

+void
+togglefloat(Arg *arg) {
+       if (!sel || arrange == dofloat)
+               return;
+       sel->isfloat = !sel->isfloat;
+       arrange();
+}
+

 void
 togglemode(Arg *arg) {
        arrange = (arrange == dofloat) ? dotile : dofloat;
        if(sel)
 void
 togglemode(Arg *arg) {
        arrange = (arrange == dofloat) ? dotile : dofloat;
        if(sel)

-               arrange(NULL);
+               arrange();

        else
                drawstatus();
 }
        else
                drawstatus();
 }


@@ -284,8 +276,7 @@ toggleview(Arg *arg) {
        for(i = 0; i < ntags && !seltag[i]; i++);
        if(i == ntags)
                seltag[arg->i] = True; /* cannot toggle last view */
        for(i = 0; i < ntags && !seltag[i]; i++);
        if(i == ntags)
                seltag[arg->i] = True; /* cannot toggle last view */

-       reorder();
-       arrange(NULL);
+       arrange();

 }
 
 void
 }
 
 void


@@ -293,20 +284,10 @@ view(Arg *arg) {
        unsigned int i;
 
        for(i = 0; i < ntags; i++)
        unsigned int i;
 
        for(i = 0; i < ntags; i++)

-               seltag[i] = False;
-       seltag[arg->i] = True;
-       reorder();
-       arrange(NULL);
-}
-
-void
-viewall(Arg *arg) {
-       unsigned int i;
-
-       for(i = 0; i < ntags; i++)
-               seltag[i] = True;
-       reorder();
-       arrange(NULL);
+               seltag[i] = (arg->i == -1) ? True : False;
+       if(arg->i >= 0 && arg->i < ntags)
+               seltag[arg->i] = True;
+       arrange();

 }
 
 void
 }
 
 void


@@ -316,26 +297,25 @@ zoom(Arg *arg) {
 
        if(!sel)
                return;
 
        if(!sel)
                return;

-

        if(sel->isfloat || (arrange == dofloat)) {
                togglemax(sel);
                return;
        }
        if(sel->isfloat || (arrange == dofloat)) {
                togglemax(sel);
                return;
        }

+       for(n = 0, c = nexttiled(clients); c; c = nexttiled(c->next))
+               n++;

 
 

-       for(n = 0, c = clients; c; c = c->next)
-               if(isvisible(c) && !c->isfloat)
-                       n++;
-       if(n < 2 || (arrange == dofloat))
-               return;
-
-       if((c = sel) == nexttiled(clients))
-               if(!(c = nexttiled(c->next)))
+       c = sel;
+       if(n <= nmaster || (arrange == dofloat))
+               pop(c);
+       else if(ismaster(sel)) {
+               if(!(c = topofstack()))

                        return;
                        return;

-       detach(c);
-       if(clients)
-               clients->prev = c;
-       c->next = clients;
-       clients = c;
+               swap(c, sel);
+               c = sel;
+       }
+       else
+               pop(c);
+

        focus(c);
        focus(c);

-       arrange(NULL);
+       arrange();

 }
 }