Xinqi Bao's Git

projects / dwm.git / blobdiff
summary | log | commit | diff | tree
raw | inline | side by side
add an additional check in resize() to prevent a crash of dwm
[dwm.git] / event.c
diff --git a/event.c b/event.c
index 19db371..6386659 100644 (file)
--- a/event.c
+++ b/event.c
@@ -1,7 +1,8 @@
-/* (C)opyright MMVI Anselm R. Garbe <garbeam at gmail dot com>
+/* (C)opyright MMVI-MMVII Anselm R. Garbe <garbeam at gmail dot com>
  * See LICENSE file for license details.
  */
 #include "dwm.h"
  * See LICENSE file for license details.
  */
 #include "dwm.h"
+#include <stdio.h>
 #include <stdlib.h>
 #include <X11/keysym.h>
 #include <X11/Xatom.h>
 #include <stdlib.h>
 #include <X11/keysym.h>
 #include <X11/Xatom.h>
@@ -11,8 +12,8 @@
 typedef struct {
        unsigned long mod;
        KeySym keysym;
 typedef struct {
        unsigned long mod;
        KeySym keysym;
-       void (*func)(Arg *arg);
-       Arg arg;
+       void (*func)(const char *arg);
+       const char *arg;
 } Key;
 
 KEYS
 } Key;
 
 KEYS
@@ -20,43 +21,52 @@ KEYS
 #define CLEANMASK(mask) (mask & ~(numlockmask | LockMask))
 #define MOUSEMASK              (BUTTONMASK | PointerMotionMask)
 
 #define CLEANMASK(mask) (mask & ~(numlockmask | LockMask))
 #define MOUSEMASK              (BUTTONMASK | PointerMotionMask)
 
+static Client *
+getclient(Window w) {
+       Client *c;
+
+       for(c = clients; c && c->win != w; c = c->next);
+       return c;
+}
+
 static void
 movemouse(Client *c) {
 static void
 movemouse(Client *c) {
-       int x1, y1, ocx, ocy, di;
+       int x1, y1, ocx, ocy, di, nx, ny;
        unsigned int dui;
        Window dummy;
        XEvent ev;
 
        unsigned int dui;
        Window dummy;
        XEvent ev;
 
-       ocx = c->x;
-       ocy = c->y;
+       ocx = nx = c->x;
+       ocy = ny = c->y;
        if(XGrabPointer(dpy, root, False, MOUSEMASK, GrabModeAsync, GrabModeAsync,
                        None, cursor[CurMove], CurrentTime) != GrabSuccess)
                return;
        c->ismax = False;
        XQueryPointer(dpy, root, &dummy, &dummy, &x1, &y1, &di, &di, &dui);
        for(;;) {
        if(XGrabPointer(dpy, root, False, MOUSEMASK, GrabModeAsync, GrabModeAsync,
                        None, cursor[CurMove], CurrentTime) != GrabSuccess)
                return;
        c->ismax = False;
        XQueryPointer(dpy, root, &dummy, &dummy, &x1, &y1, &di, &di, &dui);
        for(;;) {
-               XMaskEvent(dpy, MOUSEMASK | ExposureMask, &ev);
+               XMaskEvent(dpy, MOUSEMASK | ExposureMask | SubstructureRedirectMask, &ev);
                switch (ev.type) {
                case ButtonRelease:
                switch (ev.type) {
                case ButtonRelease:
-                       resize(c, True, TopLeft);
                        XUngrabPointer(dpy, CurrentTime);
                        return;
                        XUngrabPointer(dpy, CurrentTime);
                        return;
+               case ConfigureRequest:
                case Expose:
                case Expose:
-                       handler[Expose](&ev);
+               case MapRequest:
+                       handler[ev.type](&ev);
                        break;
                case MotionNotify:
                        XSync(dpy, False);
                        break;
                case MotionNotify:
                        XSync(dpy, False);
-                       c->x = ocx + (ev.xmotion.x - x1);
-                       c->y = ocy + (ev.xmotion.y - y1);
-                       if(abs(c->x) < SNAP)
-                               c->x = sx;
-                       else if(abs((sx + sw) - (c->x + c->w)) < SNAP)
-                               c->x = sw - c->w - 2 * BORDERPX;
-                       if(abs((sy + bh) - c->y) < SNAP)
-                               c->y = sy + bh;
-                       else if(abs((sy + sh) - (c->y + c->h)) < SNAP)
-                               c->y = sh - c->h - 2 * BORDERPX;
-                       resize(c, False, TopLeft);
+                       nx = ocx + (ev.xmotion.x - x1);
+                       ny = ocy + (ev.xmotion.y - y1);
+                       if(abs(wax + nx) < SNAP)
+                               nx = wax;
+                       else if(abs((wax + waw) - (nx + c->w + 2 * c->border)) < SNAP)
+                               nx = wax + waw - c->w - 2 * c->border;
+                       if(abs(way - ny) < SNAP)
+                               ny = way;
+                       else if(abs((way + wah) - (ny + c->h + 2 * c->border)) < SNAP)
+                               ny = way + wah - c->h - 2 * c->border;
+                       resize(c, nx, ny, c->w, c->h, False);
                        break;
                }
        }
                        break;
                }
        }
@@ -66,7 +76,6 @@ static void
 resizemouse(Client *c) {
        int ocx, ocy;
        int nw, nh;
 resizemouse(Client *c) {
        int ocx, ocy;
        int nw, nh;
-       Corner sticky;
        XEvent ev;
 
        ocx = c->x;
        XEvent ev;
 
        ocx = c->x;
@@ -75,30 +84,28 @@ resizemouse(Client *c) {
                        None, cursor[CurResize], CurrentTime) != GrabSuccess)
                return;
        c->ismax = False;
                        None, cursor[CurResize], CurrentTime) != GrabSuccess)
                return;
        c->ismax = False;
-       XWarpPointer(dpy, None, c->win, 0, 0, 0, 0, c->w, c->h);
+       XWarpPointer(dpy, None, c->win, 0, 0, 0, 0, c->w + c->border - 1, c->h + c->border - 1);
        for(;;) {
        for(;;) {
-               XMaskEvent(dpy, MOUSEMASK | ExposureMask, &ev);
+               XMaskEvent(dpy, MOUSEMASK | ExposureMask | SubstructureRedirectMask , &ev);
                switch(ev.type) {
                case ButtonRelease:
                switch(ev.type) {
                case ButtonRelease:
-                       resize(c, True, TopLeft);
+                       XWarpPointer(dpy, None, c->win, 0, 0, 0, 0,
+                                       c->w + c->border - 1, c->h + c->border - 1);
                        XUngrabPointer(dpy, CurrentTime);
                        XUngrabPointer(dpy, CurrentTime);
+                       while(XCheckMaskEvent(dpy, EnterWindowMask, &ev));
                        return;
                        return;
+               case ConfigureRequest:
                case Expose:
                case Expose:
-                       handler[Expose](&ev);
+               case MapRequest:
+                       handler[ev.type](&ev);
                        break;
                case MotionNotify:
                        XSync(dpy, False);
                        break;
                case MotionNotify:
                        XSync(dpy, False);
-                       if((nw = abs(ocx - ev.xmotion.x)))
-                               c->w = nw;
-                       if((nh = abs(ocy - ev.xmotion.y)))
-                               c->h = nh;
-                       c->x = (ocx <= ev.xmotion.x) ? ocx : ocx - c->w;
-                       c->y = (ocy <= ev.xmotion.y) ? ocy : ocy - c->h;
-                       if(ocx <= ev.xmotion.x)
-                               sticky = (ocy <= ev.xmotion.y) ? TopLeft : BotLeft;
-                       else
-                               sticky = (ocy <= ev.xmotion.y) ? TopRight : BotRight;
-                       resize(c, True, sticky);
+                       if((nw = ev.xmotion.x - ocx - 2 * c->border + 1) <= 0)
+                               nw = 1;
+                       if((nh = ev.xmotion.y - ocy - 2 * c->border + 1) <= 0)
+                               nh = 1;
+                       resize(c, c->x, c->y, nw, nh, True);
                        break;
                }
        }
                        break;
                }
        }
@@ -106,46 +113,53 @@ resizemouse(Client *c) {
 
 static void
 buttonpress(XEvent *e) {
 
 static void
 buttonpress(XEvent *e) {
-       int x;
-       Arg a;
+       static char buf[32];
+       unsigned int i, x;
        Client *c;
        XButtonPressedEvent *ev = &e->xbutton;
 
        Client *c;
        XButtonPressedEvent *ev = &e->xbutton;
 
+       buf[0] = 0;
        if(barwin == ev->window) {
                x = 0;
        if(barwin == ev->window) {
                x = 0;
-               for(a.i = 0; a.i < ntags; a.i++) {
-                       x += textw(tags[a.i]);
+               for(i = 0; i < ntags; i++) {
+                       x += textw(tags[i]);
                        if(ev->x < x) {
                        if(ev->x < x) {
+                               snprintf(buf, sizeof buf, "%d", i);
                                if(ev->button == Button1) {
                                        if(ev->state & MODKEY)
                                if(ev->button == Button1) {
                                        if(ev->state & MODKEY)
-                                               tag(&a);
+                                               tag(buf);
                                        else
                                        else
-                                               view(&a);
+                                               view(buf);
                                }
                                else if(ev->button == Button3) {
                                        if(ev->state & MODKEY)
                                }
                                else if(ev->button == Button3) {
                                        if(ev->state & MODKEY)
-                                               toggletag(&a);
+                                               toggletag(buf);
                                        else
                                        else
-                                               toggleview(&a);
+                                               toggleview(buf);
                                }
                                return;
                        }
                }
                                }
                                return;
                        }
                }
-               if((ev->x < x + bmw) && (ev->button == Button1))
-                       togglemode(NULL);
+               if(ev->x < x + blw)
+                       switch(ev->button) {
+                       case Button1:
+                               setlayout(NULL);
+                               break;
+                       }
        }
        else if((c = getclient(ev->window))) {
                focus(c);
                if(CLEANMASK(ev->state) != MODKEY)
                        return;
        }
        else if((c = getclient(ev->window))) {
                focus(c);
                if(CLEANMASK(ev->state) != MODKEY)
                        return;
-               if(ev->button == Button1 && (arrange == dofloat || c->isfloat)) {
+               if(ev->button == Button1 && (lt->arrange == floating || c->isfloating)) {
                        restack();
                        movemouse(c);
                }
                else if(ev->button == Button2)
                        zoom(NULL);
                        restack();
                        movemouse(c);
                }
                else if(ev->button == Button2)
                        zoom(NULL);
-               else if(ev->button == Button3 && (arrange == dofloat || c->isfloat) &&
-                               !c->isfixed) {
+               else if(ev->button == Button3
+               && (lt->arrange == floating || c->isfloating) && !c->isfixed)
+               {
                        restack();
                        resizemouse(c);
                }
                        restack();
                        resizemouse(c);
                }
@@ -154,42 +168,31 @@ buttonpress(XEvent *e) {
 
 static void
 configurerequest(XEvent *e) {
 
 static void
 configurerequest(XEvent *e) {
-       unsigned long newmask;
        Client *c;
        XConfigureRequestEvent *ev = &e->xconfigurerequest;
        XWindowChanges wc;
 
        if((c = getclient(ev->window))) {
                c->ismax = False;
        Client *c;
        XConfigureRequestEvent *ev = &e->xconfigurerequest;
        XWindowChanges wc;
 
        if((c = getclient(ev->window))) {
                c->ismax = False;
-               gravitate(c, True);
-               if(ev->value_mask & CWX)
-                       c->x = ev->x;
-               if(ev->value_mask & CWY)
-                       c->y = ev->y;
-               if(ev->value_mask & CWWidth)
-                       c->w = ev->width;
-               if(ev->value_mask & CWHeight)
-                       c->h = ev->height;
                if(ev->value_mask & CWBorderWidth)
                        c->border = ev->border_width;
                if(ev->value_mask & CWBorderWidth)
                        c->border = ev->border_width;
-               gravitate(c, False);
-               wc.x = c->x;
-               wc.y = c->y;
-               wc.width = c->w;
-               wc.height = c->h;
-               newmask = ev->value_mask & (~(CWSibling | CWStackMode | CWBorderWidth));
-               if(newmask)
-                       XConfigureWindow(dpy, c->win, newmask, &wc);
-               else
-                       configure(c);
-               XSync(dpy, False);
-               if(c->isfloat) {
-                       resize(c, False, TopLeft);
-                       if(!isvisible(c))
-                               ban(c);
+               if(c->isfixed || c->isfloating || (lt->arrange == floating)) {
+                       if(ev->value_mask & CWX)
+                               c->x = ev->x;
+                       if(ev->value_mask & CWY)
+                               c->y = ev->y;
+                       if(ev->value_mask & CWWidth)
+                               c->w = ev->width;
+                       if(ev->value_mask & CWHeight)
+                               c->h = ev->height;
+                       if((ev->value_mask & (CWX | CWY))
+                       && !(ev->value_mask & (CWWidth | CWHeight)))
+                               configure(c);
+                       if(isvisible(c))
+                               XMoveResizeWindow(dpy, c->win, c->x, c->y, c->w, c->h);
                }
                else
                }
                else
-                       arrange();
+                       configure(c);
        }
        else {
                wc.x = ev->x;
        }
        else {
                wc.x = ev->x;
@@ -200,8 +203,8 @@ configurerequest(XEvent *e) {
                wc.sibling = ev->above;
                wc.stack_mode = ev->detail;
                XConfigureWindow(dpy, ev->window, ev->value_mask, &wc);
                wc.sibling = ev->above;
                wc.stack_mode = ev->detail;
                XConfigureWindow(dpy, ev->window, ev->value_mask, &wc);
-               XSync(dpy, False);
        }
        }
+       XSync(dpy, False);
 }
 
 static void
 }
 
 static void
@@ -220,45 +223,40 @@ enternotify(XEvent *e) {
 
        if(ev->mode != NotifyNormal || ev->detail == NotifyInferior)
                return;
 
        if(ev->mode != NotifyNormal || ev->detail == NotifyInferior)
                return;
-       if(((c = getclient(ev->window)) || (c = getctitle(ev->window))) && isvisible(c))
+       if((c = getclient(ev->window)) && isvisible(c))
                focus(c);
        else if(ev->window == root) {
                focus(c);
        else if(ev->window == root) {
-               issel = True;
-               XSetInputFocus(dpy, root, RevertToPointerRoot, CurrentTime);
-               drawall();
+               selscreen = True;
+               for(c = stack; c && !isvisible(c); c = c->snext);
+               focus(c);
        }
 }
 
 static void
 expose(XEvent *e) {
        }
 }
 
 static void
 expose(XEvent *e) {
-       Client *c;
        XExposeEvent *ev = &e->xexpose;
 
        if(ev->count == 0) {
                if(barwin == ev->window)
                        drawstatus();
        XExposeEvent *ev = &e->xexpose;
 
        if(ev->count == 0) {
                if(barwin == ev->window)
                        drawstatus();
-               else if((c = getctitle(ev->window)))
-                       drawtitle(c);
        }
 }
 
 static void
 keypress(XEvent *e) {
        }
 }
 
 static void
 keypress(XEvent *e) {
-       static unsigned int len = sizeof(key) / sizeof(key[0]);
+       static unsigned int len = sizeof key / sizeof key[0];
        unsigned int i;
        KeySym keysym;
        XKeyEvent *ev = &e->xkey;
 
        keysym = XKeycodeToKeysym(dpy, (KeyCode)ev->keycode, 0);
        unsigned int i;
        KeySym keysym;
        XKeyEvent *ev = &e->xkey;
 
        keysym = XKeycodeToKeysym(dpy, (KeyCode)ev->keycode, 0);
-       for(i = 0; i < len; i++) {
+       for(i = 0; i < len; i++)
                if(keysym == key[i].keysym
                if(keysym == key[i].keysym
-                       && CLEANMASK(key[i].mod) == CLEANMASK(ev->state))
+               && CLEANMASK(key[i].mod) == CLEANMASK(ev->state))
                {
                        if(key[i].func)
                {
                        if(key[i].func)
-                               key[i].func(&key[i].arg);
-                       return;
+                               key[i].func(key[i].arg);
                }
                }
-       }
 }
 
 static void
 }
 
 static void
@@ -266,8 +264,8 @@ leavenotify(XEvent *e) {
        XCrossingEvent *ev = &e->xcrossing;
 
        if((ev->window == root) && !ev->same_screen) {
        XCrossingEvent *ev = &e->xcrossing;
 
        if((ev->window == root) && !ev->same_screen) {
-               issel = False;
-               drawall();
+               selscreen = False;
+               focus(NULL);
        }
 }
 
        }
 }
 
@@ -287,11 +285,8 @@ maprequest(XEvent *e) {
 
        if(!XGetWindowAttributes(dpy, ev->window, &wa))
                return;
 
        if(!XGetWindowAttributes(dpy, ev->window, &wa))
                return;
-       if(wa.override_redirect) {
-               XSelectInput(dpy, ev->window,
-                               (StructureNotifyMask | PropertyChangeMask));
+       if(wa.override_redirect)
                return;
                return;
-       }
        if(!getclient(ev->window))
                manage(ev->window, &wa);
 }
        if(!getclient(ev->window))
                manage(ev->window, &wa);
 }
@@ -305,25 +300,21 @@ propertynotify(XEvent *e) {
        if(ev->state == PropertyDelete)
                return; /* ignore */
        if((c = getclient(ev->window))) {
        if(ev->state == PropertyDelete)
                return; /* ignore */
        if((c = getclient(ev->window))) {
-               if(ev->atom == wmatom[WMProtocols]) {
-                       c->proto = getproto(c->win);
-                       return;
-               }
                switch (ev->atom) {
                        default: break;
                        case XA_WM_TRANSIENT_FOR:
                                XGetTransientForHint(dpy, c->win, &trans);
                switch (ev->atom) {
                        default: break;
                        case XA_WM_TRANSIENT_FOR:
                                XGetTransientForHint(dpy, c->win, &trans);
-                               if(!c->isfloat && (c->isfloat = (trans != 0)))
-                                       arrange();
+                               if(!c->isfloating && (c->isfloating = (getclient(trans) != NULL)))
+                                       lt->arrange();
                                break;
                        case XA_WM_NORMAL_HINTS:
                                break;
                        case XA_WM_NORMAL_HINTS:
-                               updatesize(c);
+                               updatesizehints(c);
                                break;
                }
                if(ev->atom == XA_WM_NAME || ev->atom == netatom[NetWMName]) {
                        updatetitle(c);
                                break;
                }
                if(ev->atom == XA_WM_NAME || ev->atom == netatom[NetWMName]) {
                        updatetitle(c);
-                       resizetitle(c);
-                       drawtitle(c);
+                       if(c == sel)
+                               drawstatus();
                }
        }
 }
                }
        }
 }
@@ -355,7 +346,7 @@ void (*handler[LASTEvent]) (XEvent *) = {
 
 void
 grabkeys(void) {
 
 void
 grabkeys(void) {
-       static unsigned int len = sizeof(key) / sizeof(key[0]);
+       static unsigned int len = sizeof key / sizeof key[0];
        unsigned int i;
        KeyCode code;
 
        unsigned int i;
        KeyCode code;
 
@@ -372,14 +363,3 @@ grabkeys(void) {
                                GrabModeAsync, GrabModeAsync);
        }
 }
                                GrabModeAsync, GrabModeAsync);
        }
 }
-
-void
-procevent(void) {
-       XEvent ev;
-
-       while(XPending(dpy)) {
-               XNextEvent(dpy, &ev);
-               if(handler[ev.type])
-                       (handler[ev.type])(&ev); /* call handler */
-       }
-}