Jukka also belongs to Copyright holders after all he has contributed and done for...

[dwm.git] / util.c

diff --git a/util.c b/util.c
index 990ad28..858cb69 100644 (file)
--- a/util.c
+++ b/util.c
@@ -1,7 +1,9 @@
-/*
- * (C)opyright MMVI Anselm R. Garbe <garbeam at gmail dot com>
- * See LICENSE file for license details.
- */
+/* © 2006-2007 Anselm R. Garbe <garbeam at gmail dot com>
+ * © 2006-2007 Sander van Dijk <a dot h dot vandijk at gmail dot com>
+ * © 2006-2007 Jukka Salmi <jukka at salmi dot ch>
+ * © 2007 Premysl Hruby <dfenze at gmail dot com>
+ * © 2007 Szabolcs Nagy <nszabolcs at gmail dot com>
+ * See LICENSE file for license details. */
 #include "dwm.h"
 #include <stdarg.h>
 #include <stdio.h>
@@ -9,29 +11,19 @@
 #include <sys/wait.h>
 #include <unistd.h>
 
-/* static */
-
-static void
-bad_malloc(unsigned int size)
-{
-       eprint("fatal: could not malloc() %u bytes\n", size);
-}
-
 /* extern */
 
 void *
-emallocz(unsigned int size)
-{
+emallocz(unsigned int size) {
        void *res = calloc(1, size);
 
        if(!res)
-               bad_malloc(size);
+               eprint("fatal: could not malloc() %u bytes\n", size);
        return res;
 }
 
 void
-eprint(const char *errstr, ...)
-{
+eprint(const char *errstr, ...) {
        va_list ap;
 
        va_start(ap, errstr);
@@ -41,22 +33,22 @@ eprint(const char *errstr, ...)
 }
 
 void
-spawn(Arg *arg)
-{
+spawn(const char *arg) {
        static char *shell = NULL;
 
        if(!shell && !(shell = getenv("SHELL")))
                shell = "/bin/sh";
-
-       if(!arg->cmd)
+       if(!arg)
                return;
+       /* The double-fork construct avoids zombie processes and keeps the code
+        * clean from stupid signal handlers. */
        if(fork() == 0) {
                if(fork() == 0) {
                        if(dpy)
                                close(ConnectionNumber(dpy));
                        setsid();
-                       execl(shell, shell, "-c", arg->cmd, NULL);
-                       fprintf(stderr, "dwm: execl '%s'", arg->cmd);
+                       execl(shell, shell, "-c", arg, (char *)NULL);
+                       fprintf(stderr, "dwm: execl '%s -c %s'", shell, arg);
                        perror(" failed");
                }
                exit(0);