don't access sel in restack without checking for NULL (multihead crashing bug)

[dwm.git] / view.c

diff --git a/view.c b/view.c
index 22b1794..ac3d495 100644 (file)
--- a/view.c
+++ b/view.c
@@ -3,18 +3,65 @@
  * See LICENSE file for license details.
  */
 #include "dwm.h"
  * See LICENSE file for license details.
  */
 #include "dwm.h"

+#include <stdio.h>
+
+/* static */
+
+static Client *
+minclient()
+{
+       Client *c, *min;
+
+       for(min = c = clients; c; c = c->next)
+               if(c->weight < min->weight)
+                       min = c;
+       return min;
+}
+
+
+static void
+reorder()
+{
+       Client *c, *newclients, *tail;
+
+       newclients = tail = NULL;
+       while((c = minclient())) {
+               detach(c);
+               if(tail) {
+                       c->prev = tail;
+                       tail->next = c;
+                       tail = c;
+               }
+               else
+                       tail = newclients = c;
+       }
+       clients = newclients;
+}

 
 /* extern */
 
 void (*arrange)(Arg *) = DEFMODE;
 
 
 /* extern */
 
 void (*arrange)(Arg *) = DEFMODE;
 

+void
+detach(Client *c)
+{
+       if(c->prev)
+               c->prev->next = c->next;
+       if(c->next)
+               c->next->prev = c->prev;
+       if(c == clients)
+               clients = c->next;
+       c->next = c->prev = NULL;
+}
+

 void
 dofloat(Arg *arg)
 {
        Client *c;
 
 void
 dofloat(Arg *arg)
 {
        Client *c;
 

+       maximized = False;
+

        for(c = clients; c; c = c->next) {
        for(c = clients; c; c = c->next) {

-               c->ismax = False;

                if(isvisible(c)) {
                        resize(c, True, TopLeft);
                }
                if(isvisible(c)) {
                        resize(c, True, TopLeft);
                }


@@ -22,11 +69,7 @@ dofloat(Arg *arg)
                        ban(c);
        }
        if(!sel || !isvisible(sel))
                        ban(c);
        }
        if(!sel || !isvisible(sel))

-               sel = getnext(clients);
-       if(sel)
-               focus(sel);
-       else
-               XSetInputFocus(dpy, root, RevertToPointerRoot, CurrentTime);
+               focus(getnext(clients));

        restack();
 }
 
        restack();
 }
 


@@ -36,6 +79,8 @@ dotile(Arg *arg)
        int h, i, n, w;
        Client *c;
 
        int h, i, n, w;
        Client *c;
 

+       maximized = False;
+

        w = sw - mw;
        for(n = 0, c = clients; c; c = c->next)
                if(isvisible(c) && !c->isfloat)
        w = sw - mw;
        for(n = 0, c = clients; c; c = c->next)
                if(isvisible(c) && !c->isfloat)


@@ -47,7 +92,6 @@ dotile(Arg *arg)
                h = sh - bh;
 
        for(i = 0, c = clients; c; c = c->next) {
                h = sh - bh;
 
        for(i = 0, c = clients; c; c = c->next) {

-               c->ismax = False;

                if(isvisible(c)) {
                        if(c->isfloat) {
                                resize(c, True, TopLeft);
                if(isvisible(c)) {
                        if(c->isfloat) {
                                resize(c, True, TopLeft);


@@ -87,11 +131,7 @@ dotile(Arg *arg)
                        ban(c);
        }
        if(!sel || !isvisible(sel))
                        ban(c);
        }
        if(!sel || !isvisible(sel))

-               sel = getnext(clients);
-       if(sel)
-               focus(sel);
-       else
-               XSetInputFocus(dpy, root, RevertToPointerRoot, CurrentTime);
+               focus(getnext(clients));

        restack();
 }
 
        restack();
 }
 


@@ -167,22 +207,24 @@ restack()
 
        fi = 0;
        mi = 2 * f;
 
        fi = 0;
        mi = 2 * f;

-       if(sel->isfloat || arrange == dofloat) {
-               wins[fi++] = sel->title;
-               wins[fi++] = sel->win;
-       }
-       else {
-               wins[mi++] = sel->title;
-               wins[mi++] = sel->win;
+       if(sel) {
+               if(sel->isfloat || arrange == dofloat) {
+                       wins[fi++] = sel->twin;
+                       wins[fi++] = sel->win;
+               }
+               else {
+                       wins[mi++] = sel->twin;
+                       wins[mi++] = sel->win;
+               }

        }
        for(c = clients; c; c = c->next)
                if(isvisible(c) && c != sel) {
                        if(c->isfloat || arrange == dofloat) {
        }
        for(c = clients; c; c = c->next)
                if(isvisible(c) && c != sel) {
                        if(c->isfloat || arrange == dofloat) {

-                               wins[fi++] = c->title;
+                               wins[fi++] = c->twin;

                                wins[fi++] = c->win;
                        }
                        else {
                                wins[fi++] = c->win;
                        }
                        else {

-                               wins[mi++] = c->title;
+                               wins[mi++] = c->twin;

                                wins[mi++] = c->win;
                        }
                }
                                wins[mi++] = c->win;
                        }
                }


@@ -211,6 +253,7 @@ toggleview(Arg *arg)
        for(i = 0; i < ntags && !seltag[i]; i++);
        if(i == ntags)
                seltag[arg->i] = True; /* cannot toggle last view */
        for(i = 0; i < ntags && !seltag[i]; i++);
        if(i == ntags)
                seltag[arg->i] = True; /* cannot toggle last view */

+       reorder();

        arrange(NULL);
 }
 
        arrange(NULL);
 }
 


@@ -222,32 +265,36 @@ view(Arg *arg)
        for(i = 0; i < ntags; i++)
                seltag[i] = False;
        seltag[arg->i] = True;
        for(i = 0; i < ntags; i++)
                seltag[i] = False;
        seltag[arg->i] = True;

+       reorder();
+       arrange(NULL);
+}
+
+void
+viewall(Arg *arg)
+{
+       unsigned int i;
+
+       for(i = 0; i < ntags; i++)
+               seltag[i] = True;
+       reorder();

        arrange(NULL);
 }
 
 void
 zoom(Arg *arg)
 {
        arrange(NULL);
 }
 
 void
 zoom(Arg *arg)
 {

-       Client *c;
+       Client *c = sel;

 
 

-       if(!sel || (arrange != dotile) || sel->isfloat || sel->ismax)
+       if(!c || (arrange != dotile) || c->isfloat || maximized)

                return;
 
                return;
 

-       if(sel == getnext(clients))  {
-               if((c = getnext(sel->next)))
-                       sel = c;
-               else
+       if(c == getnext(clients))
+               if(!(c = getnext(c->next)))

                        return;
                        return;

-       }
-
-       /* pop */
-       sel->prev->next = sel->next;
-       if(sel->next)
-               sel->next->prev = sel->prev;
-       sel->prev = NULL;
-       clients->prev = sel;
-       sel->next = clients;
-       clients = sel;
-       focus(sel);
+       detach(c);
+       c->next = clients;
+       clients->prev = c;
+       clients = c;
+       focus(c);

        arrange(NULL);
 }
        arrange(NULL);
 }