allowing nmaster=0 (I think that's a straight idea)

[dwm.git] / util.c

diff --git a/util.c b/util.c
index 2414b39..7d7cb1a 100644 (file)
--- a/util.c
+++ b/util.c
@@ -1,5 +1,4 @@
-/*
- * (C)opyright MMVI Anselm R. Garbe <garbeam at gmail dot com>
+/* (C)opyright MMVI-MMVII Anselm R. Garbe <garbeam at gmail dot com>
  * See LICENSE file for license details.
  */
 #include "dwm.h"
@@ -9,29 +8,19 @@
 #include <sys/wait.h>
 #include <unistd.h>
 
-/* static */
-
-static void
-bad_malloc(unsigned int size)
-{
-       eprint("fatal: could not malloc() %u bytes\n", size);
-}
-
 /* extern */
 
 void *
-emallocz(unsigned int size)
-{
+emallocz(unsigned int size) {
        void *res = calloc(1, size);
 
        if(!res)
-               bad_malloc(size);
+               eprint("fatal: could not malloc() %u bytes\n", size);
        return res;
 }
 
 void
-eprint(const char *errstr, ...)
-{
+eprint(const char *errstr, ...) {
        va_list ap;
 
        va_start(ap, errstr);
@@ -41,30 +30,30 @@ eprint(const char *errstr, ...)
 }
 
 void *
-erealloc(void *ptr, unsigned int size)
-{
+erealloc(void *ptr, unsigned int size) {
        void *res = realloc(ptr, size);
+
        if(!res)
-               bad_malloc(size);
+               eprint("fatal: could not malloc() %u bytes\n", size);
        return res;
 }
 
 void
-spawn(Arg *arg)
-{
+spawn(Arg *arg) {
        static char *shell = NULL;
 
        if(!shell && !(shell = getenv("SHELL")))
                shell = "/bin/sh";
-
        if(!arg->cmd)
                return;
+       /* The double-fork construct avoids zombie processes and keeps the code
+        * clean from stupid signal handlers. */
        if(fork() == 0) {
                if(fork() == 0) {
                        if(dpy)
                                close(ConnectionNumber(dpy));
                        setsid();
-                       execl(shell, shell, "-c", arg->cmd, NULL);
+                       execl(shell, shell, "-c", arg->cmd, (char *)NULL);
                        fprintf(stderr, "dwm: execl '%s -c %s'", shell, arg->cmd);
                        perror(" failed");
                }