another small optimisation

[dwm.git] / dwm.c

diff --git a/dwm.c b/dwm.c
index 7a6b82f..f7e9e84 100644 (file)
--- a/dwm.c
+++ b/dwm.c
@@ -51,7 +51,7 @@
 #define MOUSEMASK               (BUTTONMASK|PointerMotionMask)
 #define WIDTH(X)                ((X)->w + 2 * (X)->bw)
 #define HEIGHT(X)               ((X)->h + 2 * (X)->bw)
 #define MOUSEMASK               (BUTTONMASK|PointerMotionMask)
 #define WIDTH(X)                ((X)->w + 2 * (X)->bw)
 #define HEIGHT(X)               ((X)->h + 2 * (X)->bw)

-#define TAGMASK                 ((int)((1 << LENGTH(tags)) - 1))
+#define TAGMASK                 ((1 << LENGTH(tags)) - 1)

 #define TEXTW(X)                (textnw(X, strlen(X)) + dc.font.height)
 
 /* enums */
 #define TEXTW(X)                (textnw(X, strlen(X)) + dc.font.height)
 
 /* enums */


@@ -207,7 +207,7 @@ static void setlayout(const Arg *arg);
 static void setmfact(const Arg *arg);
 static void setup(void);
 static void showhide(Client *c);
 static void setmfact(const Arg *arg);
 static void setup(void);
 static void showhide(Client *c);

-static void sigchld(int signal);
+static void sigchld(int unused);

 static void spawn(const Arg *arg);
 static void tag(const Arg *arg);
 static void tagmon(const Arg *arg);
 static void spawn(const Arg *arg);
 static void tag(const Arg *arg);
 static void tagmon(const Arg *arg);


@@ -350,9 +350,9 @@ applysizehints(Client *c, int *x, int *y, int *w, int *h, Bool interact) {
                /* adjust for aspect limits */
                if(c->mina > 0 && c->maxa > 0) {
                        if(c->maxa < (float)*w / *h)
                /* adjust for aspect limits */
                if(c->mina > 0 && c->maxa > 0) {
                        if(c->maxa < (float)*w / *h)

-                               *w = *h * c->maxa;
+                               *w = *h * c->maxa + 0.5;

                        else if(c->mina < (float)*h / *w)
                        else if(c->mina < (float)*h / *w)

-                               *h = *w * c->mina;
+                               *h = *w * c->mina + 0.5;

                }
                if(baseismin) { /* increment calculation requires this */
                        *w -= c->basew;
                }
                if(baseismin) { /* increment calculation requires this */
                        *w -= c->basew;


@@ -380,7 +380,6 @@ void
 arrange(void) {
        Monitor *m;
 
 arrange(void) {
        Monitor *m;
 

-       /* optimise two loops into one, check focus(NULL) */

        for(m = mons; m; m = m->next)
                showhide(m->stack);
        focus(NULL);
        for(m = mons; m; m = m->next)
                showhide(m->stack);
        focus(NULL);


@@ -440,7 +439,7 @@ buttonpress(XEvent *e) {
        }
        for(i = 0; i < LENGTH(buttons); i++)
                if(click == buttons[i].click && buttons[i].func && buttons[i].button == ev->button
        }
        for(i = 0; i < LENGTH(buttons); i++)
                if(click == buttons[i].click && buttons[i].func && buttons[i].button == ev->button

-                  && CLEANMASK(buttons[i].mask) == CLEANMASK(ev->state))
+               && CLEANMASK(buttons[i].mask) == CLEANMASK(ev->state))

                        buttons[i].func(click == ClkTagBar && buttons[i].arg.i == 0 ? &arg : &buttons[i].arg);
 }
 
                        buttons[i].func(click == ClkTagBar && buttons[i].arg.i == 0 ? &arg : &buttons[i].arg);
 }
 


@@ -565,9 +564,9 @@ configurerequest(XEvent *e) {
                                c->w = ev->width;
                        if(ev->value_mask & CWHeight)
                                c->h = ev->height;
                                c->w = ev->width;
                        if(ev->value_mask & CWHeight)
                                c->h = ev->height;

-                       if((c->x - m->mx + c->w) > m->mw && c->isfloating)
+                       if((c->x + c->w) > m->mx + m->mw && c->isfloating)

                                c->x = m->mx + (m->mw / 2 - c->w / 2); /* center in x direction */
                                c->x = m->mx + (m->mw / 2 - c->w / 2); /* center in x direction */

-                       if((c->y - m->my + c->h) > m->mh && c->isfloating)
+                       if((c->y + c->h) > m->my + m->mh && c->isfloating)

                                c->y = m->my + (m->mh / 2 - c->h / 2); /* center in y direction */
                        if((ev->value_mask & (CWX|CWY)) && !(ev->value_mask & (CWWidth|CWHeight)))
                                configure(c);
                                c->y = m->my + (m->mh / 2 - c->h / 2); /* center in y direction */
                        if((ev->value_mask & (CWX|CWY)) && !(ev->value_mask & (CWWidth|CWHeight)))
                                configure(c);


@@ -885,7 +884,7 @@ getstate(Window w) {
        Atom real;
 
        status = XGetWindowProperty(dpy, w, wmatom[WMState], 0L, 2L, False, wmatom[WMState],
        Atom real;
 
        status = XGetWindowProperty(dpy, w, wmatom[WMState], 0L, 2L, False, wmatom[WMState],

-                       &real, &format, &n, &extra, (unsigned char **)&p);
+                                   &real, &format, &n, &extra, (unsigned char **)&p);

        if(status != Success)
                return -1;
        if(n != 0)
        if(status != Success)
                return -1;
        if(n != 0)


@@ -909,9 +908,7 @@ gettextprop(Window w, Atom atom, char *text, unsigned int size) {
        if(name.encoding == XA_STRING)
                strncpy(text, (char *)name.value, size - 1);
        else {
        if(name.encoding == XA_STRING)
                strncpy(text, (char *)name.value, size - 1);
        else {

-               if(XmbTextPropertyToTextList(dpy, &name, &list, &n) >= Success
-               && n > 0 && *list)
-               {
+               if(XmbTextPropertyToTextList(dpy, &name, &list, &n) >= Success && n > 0 && *list) {

                        strncpy(text, *list, size - 1);
                        XFreeStringList(list);
                }
                        strncpy(text, *list, size - 1);
                        XFreeStringList(list);
                }


@@ -1022,8 +1019,8 @@ keypress(XEvent *e) {
        keysym = XKeycodeToKeysym(dpy, (KeyCode)ev->keycode, 0);
        for(i = 0; i < LENGTH(keys); i++)
                if(keysym == keys[i].keysym
        keysym = XKeycodeToKeysym(dpy, (KeyCode)ev->keycode, 0);
        for(i = 0; i < LENGTH(keys); i++)
                if(keysym == keys[i].keysym

-                  && CLEANMASK(keys[i].mod) == CLEANMASK(ev->state)
-                  && keys[i].func)
+               && CLEANMASK(keys[i].mod) == CLEANMASK(ev->state)
+               && keys[i].func)

                        keys[i].func(&(keys[i].arg));
 }
 
                        keys[i].func(&(keys[i].arg));
 }
 


@@ -1168,7 +1165,7 @@ movemouse(const Arg *arg) {
                        nx = ocx + (ev.xmotion.x - x);
                        ny = ocy + (ev.xmotion.y - y);
                        if(snap && nx >= selmon->wx && nx <= selmon->wx + selmon->ww
                        nx = ocx + (ev.xmotion.x - x);
                        ny = ocy + (ev.xmotion.y - y);
                        if(snap && nx >= selmon->wx && nx <= selmon->wx + selmon->ww

-                               && ny >= selmon->wy && ny <= selmon->wy + selmon->wh) {
+                       && ny >= selmon->wy && ny <= selmon->wy + selmon->wh) {

                                if(abs(selmon->wx - nx) < snap)
                                        nx = selmon->wx;
                                else if(abs((selmon->wx + selmon->ww) - (nx + WIDTH(c))) < snap)
                                if(abs(selmon->wx - nx) < snap)
                                        nx = selmon->wx;
                                else if(abs((selmon->wx + selmon->ww) - (nx + WIDTH(c))) < snap)


@@ -1178,7 +1175,7 @@ movemouse(const Arg *arg) {
                                else if(abs((selmon->wy + selmon->wh) - (ny + HEIGHT(c))) < snap)
                                        ny = selmon->wy + selmon->wh - HEIGHT(c);
                                if(!c->isfloating && selmon->lt[selmon->sellt]->arrange
                                else if(abs((selmon->wy + selmon->wh) - (ny + HEIGHT(c))) < snap)
                                        ny = selmon->wy + selmon->wh - HEIGHT(c);
                                if(!c->isfloating && selmon->lt[selmon->sellt]->arrange

-                                                 && (abs(nx - c->x) > snap || abs(ny - c->y) > snap))
+                               && (abs(nx - c->x) > snap || abs(ny - c->y) > snap))

                                        togglefloating(NULL);
                        }
                        if(!selmon->lt[selmon->sellt]->arrange || c->isfloating)
                                        togglefloating(NULL);
                        }
                        if(!selmon->lt[selmon->sellt]->arrange || c->isfloating)


@@ -1238,8 +1235,8 @@ propertynotify(XEvent *e) {
                }
                if(ev->atom == XA_WM_NAME || ev->atom == netatom[NetWMName]) {
                        updatetitle(c);
                }
                if(ev->atom == XA_WM_NAME || ev->atom == netatom[NetWMName]) {
                        updatetitle(c);

-                       if(c == selmon->sel)
-                               drawbars();
+                       if(c == c->mon->sel)
+                               drawbar(c->mon);

                }
        }
 }
                }
        }
 }


@@ -1279,7 +1276,7 @@ resizemouse(const Arg *arg) {
        ocx = c->x;
        ocy = c->y;
        if(XGrabPointer(dpy, root, False, MOUSEMASK, GrabModeAsync, GrabModeAsync,
        ocx = c->x;
        ocy = c->y;
        if(XGrabPointer(dpy, root, False, MOUSEMASK, GrabModeAsync, GrabModeAsync,

-       None, cursor[CurResize], CurrentTime) != GrabSuccess)
+                       None, cursor[CurResize], CurrentTime) != GrabSuccess)

                return;
        XWarpPointer(dpy, None, c->win, 0, 0, 0, 0, c->w + c->bw - 1, c->h + c->bw - 1);
        do {
                return;
        XWarpPointer(dpy, None, c->win, 0, 0, 0, 0, c->w + c->bw - 1, c->h + c->bw - 1);
        do {


@@ -1294,9 +1291,10 @@ resizemouse(const Arg *arg) {
                        nw = MAX(ev.xmotion.x - ocx - 2 * c->bw + 1, 1);
                        nh = MAX(ev.xmotion.y - ocy - 2 * c->bw + 1, 1);
                        if(snap && nw >= selmon->wx && nw <= selmon->wx + selmon->ww
                        nw = MAX(ev.xmotion.x - ocx - 2 * c->bw + 1, 1);
                        nh = MAX(ev.xmotion.y - ocy - 2 * c->bw + 1, 1);
                        if(snap && nw >= selmon->wx && nw <= selmon->wx + selmon->ww

-                               && nh >= selmon->wy && nh <= selmon->wy + selmon->wh) {
+                       && nh >= selmon->wy && nh <= selmon->wy + selmon->wh)
+                       {

                                if(!c->isfloating && selmon->lt[selmon->sellt]->arrange
                                if(!c->isfloating && selmon->lt[selmon->sellt]->arrange

-                                  && (abs(nw - c->w) > snap || abs(nh - c->h) > snap))
+                               && (abs(nw - c->w) > snap || abs(nh - c->h) > snap))

                                        togglefloating(NULL);
                        }
                        if(!selmon->lt[selmon->sellt]->arrange || c->isfloating)
                                        togglefloating(NULL);
                        }
                        if(!selmon->lt[selmon->sellt]->arrange || c->isfloating)


@@ -1430,6 +1428,9 @@ setup(void) {
        int w;
        XSetWindowAttributes wa;
 
        int w;
        XSetWindowAttributes wa;
 

+       /* clean up any zombies immediately */
+       sigchld(0);
+

        /* init screen */
        screen = DefaultScreen(dpy);
        root = RootWindow(dpy, screen);
        /* init screen */
        screen = DefaultScreen(dpy);
        root = RootWindow(dpy, screen);


@@ -1473,8 +1474,8 @@ setup(void) {
        /* select for events */
        wa.cursor = cursor[CurNormal];
        wa.event_mask = SubstructureRedirectMask|SubstructureNotifyMask|ButtonPressMask
        /* select for events */
        wa.cursor = cursor[CurNormal];
        wa.event_mask = SubstructureRedirectMask|SubstructureNotifyMask|ButtonPressMask

-                       |EnterWindowMask|LeaveWindowMask|StructureNotifyMask
-                       |PropertyChangeMask;
+                       |EnterWindowMask|LeaveWindowMask|StructureNotifyMask
+                       |PropertyChangeMask;

        XChangeWindowAttributes(dpy, root, CWEventMask|CWCursor, &wa);
        XSelectInput(dpy, root, wa.event_mask);
        grabkeys();
        XChangeWindowAttributes(dpy, root, CWEventMask|CWCursor, &wa);
        XSelectInput(dpy, root, wa.event_mask);
        grabkeys();


@@ -1498,13 +1499,14 @@ showhide(Client *c) {
 
 
 void
 
 
 void

-sigchld(int signal) {
+sigchld(int unused) {
+       if(signal(SIGCHLD, sigchld) == SIG_ERR)
+               die("Can't install SIGCHLD handler");

        while(0 < waitpid(-1, NULL, WNOHANG));
 }
 
 void
 spawn(const Arg *arg) {
        while(0 < waitpid(-1, NULL, WNOHANG));
 }
 
 void
 spawn(const Arg *arg) {

-       signal(SIGCHLD, sigchld);

        if(fork() == 0) {
                if(dpy)
                        close(ConnectionNumber(dpy));
        if(fork() == 0) {
                if(dpy)
                        close(ConnectionNumber(dpy));


@@ -1593,23 +1595,23 @@ togglefloating(const Arg *arg) {
 
 void
 toggletag(const Arg *arg) {
 
 void
 toggletag(const Arg *arg) {

-       unsigned int mask;
+       unsigned int newtags;

 
        if(!selmon->sel)
                return;
 
        if(!selmon->sel)
                return;

-       mask = selmon->sel->tags ^ (arg->ui & TAGMASK);
-       if(mask) {
-               selmon->sel->tags = mask;
+       newtags = selmon->sel->tags ^ (arg->ui & TAGMASK);
+       if(newtags) {
+               selmon->sel->tags = newtags;

                arrange();
        }
 }
 
 void
 toggleview(const Arg *arg) {
                arrange();
        }
 }
 
 void
 toggleview(const Arg *arg) {

-       unsigned int mask = selmon->tagset[selmon->seltags] ^ (arg->ui & TAGMASK);
+       unsigned int newtagset = selmon->tagset[selmon->seltags] ^ (arg->ui & TAGMASK);

 
 

-       if(mask) {
-               selmon->tagset[selmon->seltags] = mask;
+       if(newtagset) {
+               selmon->tagset[selmon->seltags] = newtagset;

                arrange();
        }
 }
                arrange();
        }
 }


@@ -1690,10 +1692,16 @@ updategeom(void) {
        Monitor *newmons = NULL, *m = NULL, *tm;
 
 #ifdef XINERAMA
        Monitor *newmons = NULL, *m = NULL, *tm;
 
 #ifdef XINERAMA

+       int nn;

        XineramaScreenInfo *info = NULL;
 
        if(XineramaIsActive(dpy))
                info = XineramaQueryScreens(dpy, &n);
        XineramaScreenInfo *info = NULL;
 
        if(XineramaIsActive(dpy))
                info = XineramaQueryScreens(dpy, &n);

+       for(i = 1, nn = n; i < n; i++)
+               if(info[i - 1].x_org == info[i].x_org && info[i - 1].y_org == info[i].y_org
+               && info[i - 1].width == info[i].width && info[i - 1].height == info[i].height)
+                       --nn;
+       n = nn; /* we only consider unique geometries as separate screens */

 #endif /* XINERAMA */
        /* allocate monitor(s) for the new geometry setup */
        for(i = 0; i < n; i++) {
 #endif /* XINERAMA */
        /* allocate monitor(s) for the new geometry setup */
        for(i = 0; i < n; i++) {


@@ -1809,8 +1817,8 @@ updatesizehints(Client *c) {
        else
                c->minw = c->minh = 0;
        if(size.flags & PAspect) {
        else
                c->minw = c->minh = 0;
        if(size.flags & PAspect) {

-               c->mina = (float)size.min_aspect.y / (float)size.min_aspect.x;
-               c->maxa = (float)size.max_aspect.x / (float)size.max_aspect.y;
+               c->mina = (float)size.min_aspect.y / size.min_aspect.x;
+               c->maxa = (float)size.max_aspect.x / size.max_aspect.y;

        }
        else
                c->maxa = c->mina = 0.0;
        }
        else
                c->maxa = c->mina = 0.0;