applied sanders tag()/toggletag() fixes

[dwm.git] / client.c

diff --git a/client.c b/client.c
index 589b73e..14edf7c 100644 (file)
--- a/client.c
+++ b/client.c
@@ -24,7 +24,7 @@ resizetitle(Client *c)
                c->tw = c->w + 2;
        c->tx = c->x + c->w - c->tw + 2;
        c->ty = c->y;
                c->tw = c->w + 2;
        c->tx = c->x + c->w - c->tw + 2;
        c->ty = c->y;

-       if(c->tags[tsel])
+       if(isvisible(c))

                XMoveResizeWindow(dpy, c->title, c->tx, c->ty, c->tw, c->th);
        else
                XMoveResizeWindow(dpy, c->title, c->tx + 2 * sw, c->ty, c->tw, c->th);
                XMoveResizeWindow(dpy, c->title, c->tx, c->ty, c->tw, c->th);
        else
                XMoveResizeWindow(dpy, c->title, c->tx + 2 * sw, c->ty, c->tw, c->th);


@@ -50,15 +50,16 @@ void
 focus(Client *c)
 {
        Client *old = sel;
 focus(Client *c)
 {
        Client *old = sel;

-       XEvent ev;

 
 

+       if (!issel)
+               return;
+       if(sel && sel->ismax)
+               togglemax(NULL);

        sel = c;
        if(old && old != c)
                drawtitle(old);
        drawtitle(c);
        XSetInputFocus(dpy, c->win, RevertToPointerRoot, CurrentTime);
        sel = c;
        if(old && old != c)
                drawtitle(old);
        drawtitle(c);
        XSetInputFocus(dpy, c->win, RevertToPointerRoot, CurrentTime);

-       XSync(dpy, False);
-       while(XCheckMaskEvent(dpy, EnterWindowMask, &ev));

 }
 
 void
 }
 
 void


@@ -69,14 +70,11 @@ focusnext(Arg *arg)
        if(!sel)
                return;
 
        if(!sel)
                return;
 

-       if(sel->ismax)
-               togglemax(NULL);
-

        if(!(c = getnext(sel->next)))
                c = getnext(clients);
        if(c) {
        if(!(c = getnext(sel->next)))
                c = getnext(clients);
        if(c) {

-               higher(c);

                focus(c);
                focus(c);

+               restack();

        }
 }
 
        }
 }
 


@@ -88,16 +86,13 @@ focusprev(Arg *arg)
        if(!sel)
                return;
 
        if(!sel)
                return;
 

-       if(sel->ismax)
-               togglemax(NULL);
-

        if(!(c = getprev(sel->prev))) {
                for(c = clients; c && c->next; c = c->next);
                c = getprev(c);
        }
        if(c) {
        if(!(c = getprev(sel->prev))) {
                for(c = clients; c && c->next; c = c->next);
                c = getprev(c);
        }
        if(c) {

-               higher(c);

                focus(c);
                focus(c);

+               restack();

        }
 }
 
        }
 }
 


@@ -178,13 +173,6 @@ gravitate(Client *c, Bool invert)
        c->y += dy;
 }
 
        c->y += dy;
 }
 

-void
-higher(Client *c)
-{
-       XRaiseWindow(dpy, c->win);
-       XRaiseWindow(dpy, c->title);
-}
-

 void
 killclient(Arg *arg)
 {
 void
 killclient(Arg *arg)
 {


@@ -196,13 +184,6 @@ killclient(Arg *arg)
                XKillClient(dpy, sel->win);
 }
 
                XKillClient(dpy, sel->win);
 }
 

-void
-lower(Client *c)
-{
-       XLowerWindow(dpy, c->title);
-       XLowerWindow(dpy, c->win);
-}
-

 void
 manage(Window w, XWindowAttributes *wa)
 {
 void
 manage(Window w, XWindowAttributes *wa)
 {


@@ -276,12 +257,13 @@ manage(Window w, XWindowAttributes *wa)
                        || (c->maxw && c->minw &&
                                c->maxw == c->minw && c->maxh == c->minh);
        settitle(c);
                        || (c->maxw && c->minw &&
                                c->maxw == c->minw && c->maxh == c->minh);
        settitle(c);

-       arrange(NULL);

 
 

-       /* mapping the window now prevents flicker */
-       XMapRaised(dpy, c->win);
-       XMapRaised(dpy, c->title);
-       if(c->tags[tsel])
+       if(isvisible(c))
+               sel = c;
+       arrange(NULL);
+       XMapWindow(dpy, c->win);
+       XMapWindow(dpy, c->title);
+       if(isvisible(c))

                focus(c);
 }
 
                focus(c);
 }
 


@@ -415,8 +397,8 @@ togglemax(Arg *arg)
                sel->w = sw - 2;
                sel->h = sh - 2 - bh;
 
                sel->w = sw - 2;
                sel->h = sh - 2 - bh;
 

-               higher(sel);
-               resize(sel, False, TopLeft);
+               restack();
+               resize(sel, arrange == dofloat, TopLeft);

 
                sel->x = ox;
                sel->y = oy;
 
                sel->x = ox;
                sel->y = oy;


@@ -443,22 +425,17 @@ unmanage(Client *c)
                c->next->prev = c->prev;
        if(c == clients)
                clients = c->next;
                c->next->prev = c->prev;
        if(c == clients)
                clients = c->next;

-       if(sel == c) {
-               sel = getnext(c->next);
-               if(!sel)
-                       sel = getprev(c->prev);
-               if(!sel)
-                       sel = clients;
-       }
+       if(sel == c)
+               sel = getnext(clients);

        free(c->tags);
        free(c);
 
        XSync(dpy, False);
        XSetErrorHandler(xerror);
        XUngrabServer(dpy);
        free(c->tags);
        free(c);
 
        XSync(dpy, False);
        XSetErrorHandler(xerror);
        XUngrabServer(dpy);

-       arrange(NULL);

        if(sel)
                focus(sel);
        if(sel)
                focus(sel);

+       arrange(NULL);

 }
 
 void
 }
 
 void


@@ -466,24 +443,24 @@ zoom(Arg *arg)
 {
        Client *c;
 
 {
        Client *c;
 

-       if(!sel || arrange != dotile)
+       if(!sel || (arrange != dotile) || sel->isfloat || sel->ismax)

                return;
 
                return;
 

-       if(sel == getnext(clients) && sel->next)  {
+       if(sel == getnext(clients))  {

                if((c = getnext(sel->next)))
                        sel = c;
                if((c = getnext(sel->next)))
                        sel = c;

+               else
+                       return;

        }
 
        /* pop */
        }
 
        /* pop */

-       if(sel->prev)
-               sel->prev->next = sel->next;
+       sel->prev->next = sel->next;

        if(sel->next)
                sel->next->prev = sel->prev;
        sel->prev = NULL;
        if(sel->next)
                sel->next->prev = sel->prev;
        sel->prev = NULL;

-       if(clients)
-               clients->prev = sel;
+       clients->prev = sel;

        sel->next = clients;
        clients = sel;
        sel->next = clients;
        clients = sel;

-       arrange(NULL);

        focus(sel);
        focus(sel);

+       arrange(NULL);

 }
 }