applied Jukka's patch preventing some cornercases and making the EOF error message...

[dwm.git] / view.c

diff --git a/view.c b/view.c
index 6697c90..e7d7a99 100644 (file)
--- a/view.c
+++ b/view.c
@@ -1,23 +1,10 @@
-/*
- * (C)opyright MMVI Anselm R. Garbe <garbeam at gmail dot com>
+/* (C)opyright MMVI Anselm R. Garbe <garbeam at gmail dot com>

  * See LICENSE file for license details.
  */
 #include "dwm.h"
 
 /* static */
 
  * See LICENSE file for license details.
  */
 #include "dwm.h"
 
 /* static */
 

-static Client *
-minclient(void) {
-       Client *c, *min;
-
-       if((clients && clients->isfloat) || arrange == dofloat)
-               return clients; /* don't touch floating order */
-       for(min = c = clients; c; c = c->next)
-               if(c->weight < min->weight)
-                       min = c;
-       return min;
-}
-

 static Client *
 nexttiled(Client *c) {
        for(c = getnext(c); c && c->isfloat; c = getnext(c->next));
 static Client *
 nexttiled(Client *c) {
        for(c = getnext(c); c && c->isfloat; c = getnext(c->next));


@@ -25,32 +12,17 @@ nexttiled(Client *c) {
 }
 
 static void
 }
 
 static void

-reorder(void) {
-       Client *c, *newclients, *tail;
-
-       newclients = tail = NULL;
-       while((c = minclient())) {
-               detach(c);
-               if(tail) {
-                       c->prev = tail;
-                       tail->next = c;
-                       tail = c;
-               }
-               else
-                       tail = newclients = c;
-       }
-       clients = newclients;
-}
-
-static void
-togglemax(Client *c)
-{
+togglemax(Client *c) {

        XEvent ev;
        XEvent ev;

+               
+       if(c->isfixed)
+               return;
+

        if((c->ismax = !c->ismax)) {
        if((c->ismax = !c->ismax)) {

-               c->rx = c->x; c->x = sx;
-               c->ry = c->y; c->y = bh;
-               c->rw = c->w; c->w = sw - 2 * BORDERPX;
-               c->rh = c->h; c->h = sh - bh - 2 * BORDERPX;
+               c->rx = c->x; c->x = wax;
+               c->ry = c->y; c->y = way;
+               c->rw = c->w; c->w = waw - 2 * BORDERPX;
+               c->rh = c->h; c->h = wah - 2 * BORDERPX;

        }
        else {
                c->x = c->rx;
        }
        else {
                c->x = c->rx;


@@ -64,9 +36,7 @@ togglemax(Client *c)
 
 /* extern */
 
 
 /* extern */
 

-void (*arrange)(Arg *) = DEFMODE;
-Bool isvertical = VERTICALSTACK;
-StackPos stackpos = STACKPOS;
+void (*arrange)(void) = DEFMODE;

 
 void
 detach(Client *c) {
 
 void
 detach(Client *c) {


@@ -80,7 +50,7 @@ detach(Client *c) {
 }
 
 void
 }
 
 void

-dofloat(Arg *arg) {
+dofloat(void) {

        Client *c;
 
        for(c = clients; c; c = c->next) {
        Client *c;
 
        for(c = clients; c; c = c->next) {


@@ -97,151 +67,50 @@ dofloat(Arg *arg) {
        restack();
 }
 
        restack();
 }
 

-/* This algorithm is based on a (M)aster area and a (S)tacking area.
- * It supports following arrangements:
- *     SSMMM   MMMMM   MMMSS
- *     SSMMM   SSSSS   MMMSS
- */

 void
 void

-dotile(Arg *arg) {
-       int i, n, stackw, stackh, tw, th;
+dotile(void) {
+       unsigned int i, n, mpx, stackw, th;

        Client *c;
 
        for(n = 0, c = nexttiled(clients); c; c = nexttiled(c->next))
                n++;
        Client *c;
 
        for(n = 0, c = nexttiled(clients); c; c = nexttiled(c->next))
                n++;

+       mpx = (waw * master) / 1000;
+       stackw = waw - mpx;

 
 

-       if(stackpos == StackBottom) {
-               stackw = sw;
-               stackh = sh - bh - master;
-       }
-       else {
-               stackw = sw - master;
-               stackh = sh - bh;
-       }
-
-       if(isvertical) {
-               tw = stackw;
-               if(n > 1)
-                       th = stackh / (n - 1);
-               else
-                       th = stackh;
-       }
-       else {
-               th = stackh;
-               if(n > 1)
-                       tw = stackw / (n - 1);
-               else
-                       tw = stackw;
-       }
-
-       for(i = 0, c = clients; c; c = c->next) {
+       for(i = 0, c = clients; c; c = c->next)

                if(isvisible(c)) {
                        if(c->isfloat) {
                                resize(c, True, TopLeft);
                                continue;
                        }
                        c->ismax = False;
                if(isvisible(c)) {
                        if(c->isfloat) {
                                resize(c, True, TopLeft);
                                continue;
                        }
                        c->ismax = False;

+                       c->x = wax;
+                       c->y = way;

                        if(n == 1) { /* only 1 window */
                        if(n == 1) { /* only 1 window */

-                               c->x = sx;
-                               c->y = sy + bh;
-                               c->w = sw - 2 * BORDERPX;
-                               c->h = sh - 2 * BORDERPX - bh;
+                               c->w = waw - 2 * BORDERPX;
+                               c->h = wah - 2 * BORDERPX;

                        }
                        else if(i == 0) { /* master window */
                        }
                        else if(i == 0) { /* master window */

-                               switch(stackpos) {
-                               case StackLeft:
-                                       c->x = sx + stackw;
-                                       c->y = sy + bh;
-                                       c->w = master - 2 * BORDERPX;
-                                       c->h = sh - bh - 2 * BORDERPX;
-                                       break;
-                               case StackBottom:
-                                       c->x = sx;
-                                       c->y = sy + bh;
-                                       c->w = sw - 2 * BORDERPX;
-                                       c->h = master - 2 * BORDERPX;
-                                       break;
-                               case StackRight:
-                                       c->x = sx;
-                                       c->y = sy + bh;
-                                       c->w = master - 2 * BORDERPX;
-                                       c->h = sh - bh - 2 * BORDERPX;
-                                       break;
-                               }
-                       }
-                       else if((isvertical && th > bh) || (!isvertical && tw > MINW)) {
-                               /* tile window */
-                               c->w = tw - 2 * BORDERPX;
-                               c->h = th - 2 * BORDERPX;
-                               switch(stackpos) {
-                               case StackLeft:
-                                       if(isvertical) {
-                                               c->x = sx;
-                                               c->y = sy + (i - 1) * th + bh;
-                                               if(i + 1 == n)
-                                                       c->h = sh - c->y - 2 * BORDERPX;
-                                       }
-                                       else {
-                                               c->x = sx + (i - 1) * tw;
-                                               c->y = sy + bh;
-                                               if(i + 1 == n)
-                                                       c->w = sx + stackw - c->x - 2 * BORDERPX;
-                                       }
-                                       break;
-                               case StackBottom:
-                                       if(isvertical) {
-                                               c->x = sx;
-                                               c->y = sy + master + (i - 1) * th + bh;
-                                               if(i + 1 == n)
-                                                       c->h = sh - c->y - 2 * BORDERPX;
-                                       }
-                                       else {
-                                               c->x = sx + (i - 1) * tw;
-                                               c->y = sy + bh + master;
-                                               if(i + 1 == n)
-                                                       c->w = sw - c->x - 2 * BORDERPX;
-                                       }
-                                       break;
-                               case StackRight:
-                                       if(isvertical) {
-                                               c->x = sx + master;
-                                               c->y = sy + (i - 1) * th + bh;
-                                               if(i + 1 == n)
-                                                       c->h = sh - c->y - 2 * BORDERPX;
-                                       }
-                                       else {
-                                               c->x = sx + master + (i - 1) * tw;
-                                               c->y = sy + bh;
-                                               if(i + 1 == n)
-                                                       c->w = sx + stackw - c->x - 2 * BORDERPX;
-                                       }
-                                       break;
-                               }
+                               c->w = waw - stackw - 2 * BORDERPX;
+                               c->h = wah - 2 * BORDERPX;
+                               th = wah / (n - 1);

                        }
                        }

-                       else { /* fallback if th < bh resp. tw < MINW */
+                       else {  /* tile window */
+                               c->x += mpx;

                                c->w = stackw - 2 * BORDERPX;
                                c->w = stackw - 2 * BORDERPX;

-                               c->h = stackh - 2 * BORDERPX;
-                               switch(stackpos) {
-                               case StackLeft:
-                                       c->x = sx;
-                                       c->y = sy + bh;
-                                       break;
-                               case StackBottom:
-                                       c->x = sx;
-                                       c->y = sy + master;
-                                       break;
-                               case StackRight:
-                                       c->x = sx + master;
-                                       c->y = sy + bh;
-                                       break;
+                               if(th > bh) {
+                                       c->y = way + (i - 1) * th;
+                                       c->h = th - 2 * BORDERPX;

                                }
                                }

+                               else /* fallback if th < bh */
+                                       c->h = wah - 2 * BORDERPX;

                        }
                        resize(c, False, TopLeft);
                        i++;
                }
                else
                        ban(c);
                        }
                        resize(c, False, TopLeft);
                        i++;
                }
                else
                        ban(c);

-       }
+

        if(!sel || !isvisible(sel)) {
                for(c = stack; c && !isvisible(c); c = c->snext);
                focus(c);
        if(!sel || !isvisible(sel)) {
                for(c = stack; c && !isvisible(c); c = c->snext);
                focus(c);


@@ -255,7 +124,6 @@ focusnext(Arg *arg) {
    
        if(!sel)
                return;
    
        if(!sel)
                return;

-

        if(!(c = getnext(sel->next)))
                c = getnext(clients);
        if(c) {
        if(!(c = getnext(sel->next)))
                c = getnext(clients);
        if(c) {


@@ -270,7 +138,6 @@ focusprev(Arg *arg) {
 
        if(!sel)
                return;
 
        if(!sel)
                return;

-

        if(!(c = getprev(sel->prev))) {
                for(c = clients; c && c->next; c = c->next);
                c = getprev(c);
        if(!(c = getprev(sel->prev))) {
                for(c = clients; c && c->next; c = c->next);
                c = getprev(c);


@@ -292,27 +159,15 @@ isvisible(Client *c) {
 }
 
 void
 }
 
 void

-resizecol(Arg *arg) {
-       unsigned int n;
-       Client *c;
-
-       for(n = 0, c = clients; c; c = c->next)
-               if(isvisible(c) && !c->isfloat)
-                       n++;
-       if(!sel || sel->isfloat || n < 2 || (arrange == dofloat))
-               return;
-
-       if(sel == getnext(clients)) {
-               if(master + arg->i > sw - MINW || master + arg->i < MINW)
-                       return;
-               master += arg->i;
-       }
+resizemaster(Arg *arg) {
+       if(arg->i == 0)
+               master = MASTER;

        else {
        else {

-               if(master - arg->i > sw - MINW || master - arg->i < MINW)
+               if(master + arg->i > 950 || master + arg->i < 50)

                        return;
                        return;

-               master -= arg->i;
+               master += arg->i;

        }
        }

-       arrange(NULL);
+       arrange();

 }
 
 void
 }
 
 void


@@ -328,11 +183,18 @@ restack(void) {
                XRaiseWindow(dpy, sel->win);
                XRaiseWindow(dpy, sel->twin);
        }
                XRaiseWindow(dpy, sel->win);
                XRaiseWindow(dpy, sel->twin);
        }

-       if(arrange != dofloat)
+       if(arrange != dofloat) {
+               if(!sel->isfloat) {
+                       XLowerWindow(dpy, sel->twin);
+                       XLowerWindow(dpy, sel->win);
+               }

                for(c = nexttiled(clients); c; c = nexttiled(c->next)) {
                for(c = nexttiled(clients); c; c = nexttiled(c->next)) {

+                       if(c == sel)
+                               continue;

                        XLowerWindow(dpy, c->twin);
                        XLowerWindow(dpy, c->win);
                }
                        XLowerWindow(dpy, c->twin);
                        XLowerWindow(dpy, c->win);
                }

+       }

        drawall();
        XSync(dpy, False);
        while(XCheckMaskEvent(dpy, EnterWindowMask, &ev));
        drawall();
        XSync(dpy, False);
        while(XCheckMaskEvent(dpy, EnterWindowMask, &ev));


@@ -342,7 +204,7 @@ void
 togglemode(Arg *arg) {
        arrange = (arrange == dofloat) ? dotile : dofloat;
        if(sel)
 togglemode(Arg *arg) {
        arrange = (arrange == dofloat) ? dotile : dofloat;
        if(sel)

-               arrange(NULL);
+               arrange();

        else
                drawstatus();
 }
        else
                drawstatus();
 }


@@ -355,33 +217,7 @@ toggleview(Arg *arg) {
        for(i = 0; i < ntags && !seltag[i]; i++);
        if(i == ntags)
                seltag[arg->i] = True; /* cannot toggle last view */
        for(i = 0; i < ntags && !seltag[i]; i++);
        if(i == ntags)
                seltag[arg->i] = True; /* cannot toggle last view */

-       reorder();
-       arrange(NULL);
-}
-
-void
-togglestackdir(Arg *arg) {
-       if(arrange == dofloat)
-               return;
-       isvertical = !isvertical;
-       arrange(NULL);
-}
-
-void
-togglestackpos(Arg *arg) {
-       if(arrange == dofloat)
-               return;
-       if(stackpos == StackBottom)
-               stackpos = STACKPOS;
-       else
-               stackpos = StackBottom;
-       updatemaster();
-       arrange(NULL);
-}
-
-void
-updatemaster(void) {
-       master = ((stackpos == StackBottom ? sh - bh : sw) * MASTER) / 100;
+       arrange();

 }
 
 void
 }
 
 void


@@ -391,8 +227,7 @@ view(Arg *arg) {
        for(i = 0; i < ntags; i++)
                seltag[i] = False;
        seltag[arg->i] = True;
        for(i = 0; i < ntags; i++)
                seltag[i] = False;
        seltag[arg->i] = True;

-       reorder();
-       arrange(NULL);
+       arrange();

 }
 
 void
 }
 
 void


@@ -401,12 +236,9 @@ viewall(Arg *arg) {
 
        for(i = 0; i < ntags; i++)
                seltag[i] = True;
 
        for(i = 0; i < ntags; i++)
                seltag[i] = True;

-       reorder();
-       arrange(NULL);
+       arrange();

 }
 
 }
 

-
-

 void
 zoom(Arg *arg) {
        unsigned int n;
 void
 zoom(Arg *arg) {
        unsigned int n;


@@ -414,18 +246,15 @@ zoom(Arg *arg) {
 
        if(!sel)
                return;
 
        if(!sel)
                return;

-

        if(sel->isfloat || (arrange == dofloat)) {
                togglemax(sel);
                return;
        }
        if(sel->isfloat || (arrange == dofloat)) {
                togglemax(sel);
                return;
        }

-

        for(n = 0, c = clients; c; c = c->next)
                if(isvisible(c) && !c->isfloat)
                        n++;
        if(n < 2 || (arrange == dofloat))
                return;
        for(n = 0, c = clients; c; c = c->next)
                if(isvisible(c) && !c->isfloat)
                        n++;
        if(n < 2 || (arrange == dofloat))
                return;

-

        if((c = sel) == nexttiled(clients))
                if(!(c = nexttiled(c->next)))
                        return;
        if((c = sel) == nexttiled(clients))
                if(!(c = nexttiled(c->next)))
                        return;


@@ -435,5 +264,5 @@ zoom(Arg *arg) {
        c->next = clients;
        clients = c;
        focus(c);
        c->next = clients;
        clients = c;
        focus(c);

-       arrange(NULL);
+       arrange();

 }
 }