Xinqi Bao's Git
projects
/
dwm.git
/ commitdiff
summary
|
log
|
commit
|
diff
|
tree
raw
|
patch
|
inline
| side by side (from parent 1:
ed1bef1
)
reverted spawn
author
[email protected]
<unknown>
Sat, 6 Dec 2008 09:16:48 +0000
(09:16 +0000)
committer
[email protected]
<unknown>
Sat, 6 Dec 2008 09:16:48 +0000
(09:16 +0000)
dwm.c
patch
|
blob
|
history
diff --git
a/dwm.c
b/dwm.c
index
b390294
..
f7b9477
100644
(file)
--- a/
dwm.c
+++ b/
dwm.c
@@
-182,7
+182,6
@@
static void setlayout(const Arg *arg);
static void setmfact(const Arg *arg);
static void setup(void);
static void showhide(Client *c);
static void setmfact(const Arg *arg);
static void setup(void);
static void showhide(Client *c);
-static void sigchld(int signal);
static void spawn(const Arg *arg);
static void tag(const Arg *arg);
static int textnw(const char *text, unsigned int len);
static void spawn(const Arg *arg);
static void tag(const Arg *arg);
static int textnw(const char *text, unsigned int len);
@@
-1392,24
+1391,22
@@
showhide(Client *c) {
}
}
}
}
-
-void
-sigchld(int signal) {
- while(0 < waitpid(-1, NULL, WNOHANG));
-}
-
void
spawn(const Arg *arg) {
void
spawn(const Arg *arg) {
- signal(SIGCHLD, sigchld);
+ /* The double-fork construct avoids zombie processes and keeps the code
+ * clean from stupid signal handlers. */
if(fork() == 0) {
if(fork() == 0) {
- if(dpy)
- close(ConnectionNumber(dpy));
- setsid();
- execvp(((char **)arg->v)[0], (char **)arg->v);
- fprintf(stderr, "dwm: execvp %s", ((char **)arg->v)[0]);
- perror(" failed");
+ if(fork() == 0) {
+ if(dpy)
+ close(ConnectionNumber(dpy));
+ setsid();
+ execvp(((char **)arg->v)[0], (char **)arg->v);
+ fprintf(stderr, "dwm: execvp %s", ((char **)arg->v)[0]);
+ perror(" failed");
+ }
exit(0);
}
exit(0);
}
+ wait(0);
}
void
}
void