coding style notice in README.md

[slstatus.git] / slstatus.c

diff --git a/slstatus.c b/slstatus.c
index 214f667..86d27eb 100644 (file)
--- a/slstatus.c
+++ b/slstatus.c
@@ -2,10 +2,13 @@
 
 /* global libraries */
 #include <alsa/asoundlib.h>
 
 /* global libraries */
 #include <alsa/asoundlib.h>

+#include <fcntl.h>

 #include <stdarg.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <stdarg.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>

+#include <sys/types.h>
+#include <sys/stat.h>

 #include <time.h>
 #include <unistd.h>
 #include <X11/Xlib.h>
 #include <time.h>
 #include <unistd.h>
 #include <X11/Xlib.h>


@@ -13,7 +16,14 @@
 /* local libraries */
 #include "config.h"
 
 /* local libraries */
 #include "config.h"
 

+/* check file macro */
+#define CHECK_FILE(X,Y) do { \
+    if (stat(X,&Y) < 0) return -1; \
+    if (!S_ISREG(Y.st_mode)) return -1; \
+} while (0);
+

 /* functions */
 /* functions */

+int config_check();

 void setstatus(char *str);
 char *smprintf(char *fmt, ...);
 char *get_battery();
 void setstatus(char *str);
 char *smprintf(char *fmt, ...);
 char *get_battery();


@@ -27,6 +37,17 @@ char *get_wifi_signal();
 /* global variables */
 static Display *dpy;
 
 /* global variables */
 static Display *dpy;
 

+/* check configured paths */
+int
+config_check()
+{
+    struct stat fs;
+    CHECK_FILE(batterynowfile, fs);
+    CHECK_FILE(batteryfullfile, fs);
+    CHECK_FILE(tempfile, fs);
+    return 0;
+}
+

 /* set statusbar (WM_NAME) */
 void
 setstatus(char *str)
 /* set statusbar (WM_NAME) */
 void
 setstatus(char *str)


@@ -59,7 +80,7 @@ get_battery()
     /* open battery now file */
     if (!(fp = fopen(batterynowfile, "r"))) {
         fprintf(stderr, "Error opening battery file.");
     /* open battery now file */
     if (!(fp = fopen(batterynowfile, "r"))) {
         fprintf(stderr, "Error opening battery file.");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* read value */
     }
 
     /* read value */


@@ -71,7 +92,7 @@ get_battery()
     /* open battery full file */
     if (!(fp = fopen(batteryfullfile, "r"))) {
         fprintf(stderr, "Error opening battery file.");
     /* open battery full file */
     if (!(fp = fopen(batteryfullfile, "r"))) {
         fprintf(stderr, "Error opening battery file.");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* read value */
     }
 
     /* read value */


@@ -97,7 +118,7 @@ get_cpu_temperature()
     /* open temperature file */
     if (!(fp = fopen(tempfile, "r"))) {
         fprintf(stderr, "Could not open temperature file.\n");
     /* open temperature file */
     if (!(fp = fopen(tempfile, "r"))) {
         fprintf(stderr, "Could not open temperature file.\n");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* extract temperature */
     }
 
     /* extract temperature */


@@ -121,7 +142,7 @@ get_cpu_usage()
     /* open stat file */
     if (!(fp = fopen("/proc/stat","r"))) {
         fprintf(stderr, "Error opening stat file.");
     /* open stat file */
     if (!(fp = fopen("/proc/stat","r"))) {
         fprintf(stderr, "Error opening stat file.");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* read values */
     }
 
     /* read values */


@@ -136,7 +157,7 @@ get_cpu_usage()
     /* open stat file */
     if (!(fp = fopen("/proc/stat","r"))) {
         fprintf(stderr, "Error opening stat file.");
     /* open stat file */
     if (!(fp = fopen("/proc/stat","r"))) {
         fprintf(stderr, "Error opening stat file.");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* read values */
     }
 
     /* read values */


@@ -163,8 +184,8 @@ get_datetime()
     /* get time in format */
     time(&tm);
     if(!strftime(buf, bufsize, timeformat, localtime(&tm))) {
     /* get time in format */
     time(&tm);
     if(!strftime(buf, bufsize, timeformat, localtime(&tm))) {

-      fprintf(stderr, "Strftime failed.\n");
-        exit(1);
+        fprintf(stderr, "Strftime failed.\n");
+        return smprintf("n/a");

     }
 
     /* return time */
     }
 
     /* return time */


@@ -182,7 +203,7 @@ get_ram_usage()
     /* open meminfo file */
     if (!(fp = fopen("/proc/meminfo", "r"))) {
         fprintf(stderr, "Error opening meminfo file.");
     /* open meminfo file */
     if (!(fp = fopen("/proc/meminfo", "r"))) {
         fprintf(stderr, "Error opening meminfo file.");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* read the values */
     }
 
     /* read the values */


@@ -263,7 +284,7 @@ get_wifi_signal()
     /* open wifi file */
     if(!(fp = fopen(path, "r"))) {
         fprintf(stderr, "Error opening wifi operstate file.");
     /* open wifi file */
     if(!(fp = fopen(path, "r"))) {
         fprintf(stderr, "Error opening wifi operstate file.");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* read the status */
     }
 
     /* read the status */


@@ -274,13 +295,13 @@ get_wifi_signal()
 
     /* check if interface down */
     if(strcmp(status, "up\n") != 0){
 
     /* check if interface down */
     if(strcmp(status, "up\n") != 0){

-        return "n/a";
+        return smprintf("n/a");

     }
 
     /* open wifi file */
     if (!(fp = fopen("/proc/net/wireless", "r"))) {
         fprintf(stderr, "Error opening wireless file.");
     }
 
     /* open wifi file */
     if (!(fp = fopen("/proc/net/wireless", "r"))) {
         fprintf(stderr, "Error opening wireless file.");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* extract the signal strength */
     }
 
     /* extract the signal strength */


@@ -314,6 +335,12 @@ main()
     char *volume = NULL;
     char *wifi_signal = NULL;
 
     char *volume = NULL;
     char *wifi_signal = NULL;
 

+    /* check config for sanity */
+    if (config_check() < 0) {
+        fprintf(stderr, "Config error, please check paths and recompile\n");
+        exit(1);
+    }
+

     /* open display */
     if (!(dpy = XOpenDisplay(0x0))) {
         fprintf(stderr, "Cannot open display!\n");
     /* open display */
     if (!(dpy = XOpenDisplay(0x0))) {
         fprintf(stderr, "Cannot open display!\n");


@@ -343,6 +370,9 @@ main()
         free(ram_usage);
         free(volume);
         free(wifi_signal);
         free(ram_usage);
         free(volume);
         free(wifi_signal);

+
+        /* wait, "update_interval - 1" because of get_cpu_usage() which uses 1 second */
+        sleep(update_interval -1);

     }
 
     /* close display */
     }
 
     /* close display */