Fix some memory leaks

[slstatus.git] / slstatus.c

diff --git a/slstatus.c b/slstatus.c
index fa627df..1db9af8 100644 (file)
--- a/slstatus.c
+++ b/slstatus.c
@@ -2,59 +2,42 @@
 
 /* global libraries */
 #include <alsa/asoundlib.h>
 
 /* global libraries */
 #include <alsa/asoundlib.h>

+#include <fcntl.h>
+#include <locale.h>

 #include <stdarg.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <stdarg.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>

+#include <sys/types.h>
+#include <sys/stat.h>
+#include <sys/statvfs.h>

 #include <time.h>
 #include <unistd.h>
 #include <X11/Xlib.h>
 
 #include <time.h>
 #include <unistd.h>
 #include <X11/Xlib.h>
 

-/* local libraries */
+/* local headers */
+#include "slstatus.h"

 #include "config.h"
 
 #include "config.h"
 

-/* functions */
-void setstatus(char *str);
-char *smprintf(char *fmt, ...);
-char *get_battery();
-char *get_cpu_temperature();
-char *get_cpu_usage();
-char *get_datetime();
-char *get_ram_usage();
-char *get_volume();
-char *get_wifi_signal();
-
-/* global variables */
-static Display *dpy;
-
-/* set statusbar (WM_NAME) */
+/* set statusbar */

 void
 void

-setstatus(char *str)
+setstatus(const char *str)

 {
 {

+    /* set WM_NAME via X11 */

     XStoreName(dpy, DefaultRootWindow(dpy), str);
     XSync(dpy, False);
 }
 
 /* smprintf function */
 char *
     XStoreName(dpy, DefaultRootWindow(dpy), str);
     XSync(dpy, False);
 }
 
 /* smprintf function */
 char *

-smprintf(char *fmt, ...)
+smprintf(const char *fmt, ...)

 {
     va_list fmtargs;
 {
     va_list fmtargs;

-    char *ret;
-    int len;
+    char *ret = NULL;

 
     va_start(fmtargs, fmt);
 
     va_start(fmtargs, fmt);

-    len = vsnprintf(NULL, 0, fmt, fmtargs);
-    va_end(fmtargs);
-
-    ret = malloc(++len);
-    if (ret == NULL) {
-        fprintf(stderr, "Malloc error.");
-        exit(1);
-    }
-
-    va_start(fmtargs, fmt);
-    vsnprintf(ret, len, fmt, fmtargs);
+    if (vasprintf(&ret, fmt, fmtargs) < 0)
+        return NULL;

     va_end(fmtargs);
 
     return ret;
     va_end(fmtargs);
 
     return ret;


@@ -62,15 +45,29 @@ smprintf(char *fmt, ...)
 
 /* battery percentage */
 char *
 
 /* battery percentage */
 char *

-get_battery()
+get_battery(const char *battery)

 {
     int now, full, perc;
 {
     int now, full, perc;

+    char batterynowfile[64] = "";
+    char batteryfullfile[64] = "";

     FILE *fp;
 
     FILE *fp;
 

+    /* generate battery nowfile path */
+    strcat(batterynowfile, batterypath);
+    strcat(batterynowfile, battery);
+    strcat(batterynowfile, "/");
+    strcat(batterynowfile, batterynow);
+
+    /* generate battery fullfile path */
+    strcat(batteryfullfile, batterypath);
+    strcat(batteryfullfile, battery);
+    strcat(batteryfullfile, "/");
+    strcat(batteryfullfile, batteryfull);
+

     /* open battery now file */
     if (!(fp = fopen(batterynowfile, "r"))) {
     /* open battery now file */
     if (!(fp = fopen(batterynowfile, "r"))) {

-        fprintf(stderr, "Error opening battery file.");
-        exit(1);
+        fprintf(stderr, "Error opening battery file.%s",batterynowfile);
+        return smprintf("n/a");

     }
 
     /* read value */
     }
 
     /* read value */


@@ -82,7 +79,7 @@ get_battery()
     /* open battery full file */
     if (!(fp = fopen(batteryfullfile, "r"))) {
         fprintf(stderr, "Error opening battery file.");
     /* open battery full file */
     if (!(fp = fopen(batteryfullfile, "r"))) {
         fprintf(stderr, "Error opening battery file.");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* read value */
     }
 
     /* read value */


@@ -100,15 +97,15 @@ get_battery()
 
 /* cpu temperature */
 char *
 
 /* cpu temperature */
 char *

-get_cpu_temperature()
+get_cpu_temperature(const char *file)

 {
     int temperature;
     FILE *fp;
 
     /* open temperature file */
 {
     int temperature;
     FILE *fp;
 
     /* open temperature file */

-    if (!(fp = fopen(tempfile, "r"))) {
+    if (!(fp = fopen(file, "r"))) {

         fprintf(stderr, "Could not open temperature file.\n");
         fprintf(stderr, "Could not open temperature file.\n");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* extract temperature */
     }
 
     /* extract temperature */


@@ -123,7 +120,7 @@ get_cpu_temperature()
 
 /* cpu percentage */
 char *
 
 /* cpu percentage */
 char *

-get_cpu_usage()
+get_cpu_usage(const char *null)

 {
     int perc;
     long double a[4], b[4];
 {
     int perc;
     long double a[4], b[4];


@@ -132,7 +129,7 @@ get_cpu_usage()
     /* open stat file */
     if (!(fp = fopen("/proc/stat","r"))) {
         fprintf(stderr, "Error opening stat file.");
     /* open stat file */
     if (!(fp = fopen("/proc/stat","r"))) {
         fprintf(stderr, "Error opening stat file.");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* read values */
     }
 
     /* read values */


@@ -147,7 +144,7 @@ get_cpu_usage()
     /* open stat file */
     if (!(fp = fopen("/proc/stat","r"))) {
         fprintf(stderr, "Error opening stat file.");
     /* open stat file */
     if (!(fp = fopen("/proc/stat","r"))) {
         fprintf(stderr, "Error opening stat file.");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* read values */
     }
 
     /* read values */


@@ -165,26 +162,51 @@ get_cpu_usage()
 
 /* date and time */
 char *
 
 /* date and time */
 char *

-get_datetime()
+get_datetime(const char *timeformat)

 {
     time_t tm;
 {
     time_t tm;

-    size_t bufsize = 19;
+    size_t bufsize = 64;

     char *buf = malloc(bufsize);
 
     /* get time in format */
     time(&tm);
     char *buf = malloc(bufsize);
 
     /* get time in format */
     time(&tm);

+    setlocale(LC_TIME, "");

     if(!strftime(buf, bufsize, timeformat, localtime(&tm))) {
     if(!strftime(buf, bufsize, timeformat, localtime(&tm))) {

+        setlocale(LC_TIME, "C");

         fprintf(stderr, "Strftime failed.\n");
         fprintf(stderr, "Strftime failed.\n");

-        exit(1);
+        return smprintf("n/a");

     }
 
     }
 

+    setlocale(LC_TIME, "C");

     /* return time */
     /* return time */

-    return smprintf("%s", buf);
+    char *ret = smprintf("%s", buf);
+    free(buf);
+    return ret;
+}
+
+/* disk usage percentage */
+char *
+get_diskusage(const char *mountpoint)
+{
+    int perc = 0;
+    struct statvfs fs;
+
+    /* try to open mountpoint */
+    if (statvfs(mountpoint, &fs) < 0) {
+        fprintf(stderr, "Could not get filesystem info.\n");
+        return smprintf("n/a");
+    }
+
+    /* calculate percent */
+    perc = 100 * (1.0f - ((float)fs.f_bavail / (float)fs.f_blocks));
+
+    /* return perc */
+    return smprintf("%d%%", perc);

 }
 
 /* ram percentage */
 char *
 }
 
 /* ram percentage */
 char *

-get_ram_usage()
+get_ram_usage(const char *null)

 {
     int perc;
     long total, free, buffers, cached;
 {
     int perc;
     long total, free, buffers, cached;


@@ -193,7 +215,7 @@ get_ram_usage()
     /* open meminfo file */
     if (!(fp = fopen("/proc/meminfo", "r"))) {
         fprintf(stderr, "Error opening meminfo file.");
     /* open meminfo file */
     if (!(fp = fopen("/proc/meminfo", "r"))) {
         fprintf(stderr, "Error opening meminfo file.");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* read the values */
     }
 
     /* read the values */


@@ -214,7 +236,7 @@ get_ram_usage()
 
 /* alsa volume percentage */
 char *
 
 /* alsa volume percentage */
 char *

-get_volume()
+get_volume(const char *soundcard)

 {
     int mute = 0;
     long vol = 0, max = 0, min = 0;
 {
     int mute = 0;
     long vol = 0, max = 0, min = 0;


@@ -252,29 +274,27 @@ get_volume()
 
 /* wifi percentage */
 char *
 
 /* wifi percentage */
 char *

-get_wifi_signal()
+get_wifi_signal(const char *wificard)

 {
     int bufsize = 255;
     int strength;
     char buf[bufsize];
     char *datastart;
 {
     int bufsize = 255;
     int strength;
     char buf[bufsize];
     char *datastart;

-    char path_start[16] = "/sys/class/net/";
-    char path_end[11] = "/operstate";
-    char path[32];
+    char path[64];

     char status[5];
     char needle[sizeof wificard + 1];
     FILE *fp;
 
     /* generate the path name */
     memset(path, 0, sizeof path);
     char status[5];
     char needle[sizeof wificard + 1];
     FILE *fp;
 
     /* generate the path name */
     memset(path, 0, sizeof path);

-    strcat(path, path_start);
+    strcat(path, "/sys/class/net/");

     strcat(path, wificard);
     strcat(path, wificard);

-    strcat(path, path_end);
+    strcat(path, "/operstate");

 
     /* open wifi file */
     if(!(fp = fopen(path, "r"))) {
         fprintf(stderr, "Error opening wifi operstate file.");
 
     /* open wifi file */
     if(!(fp = fopen(path, "r"))) {
         fprintf(stderr, "Error opening wifi operstate file.");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* read the status */
     }
 
     /* read the status */


@@ -285,13 +305,13 @@ get_wifi_signal()
 
     /* check if interface down */
     if(strcmp(status, "up\n") != 0){
 
     /* check if interface down */
     if(strcmp(status, "up\n") != 0){

-        return "n/a";
+        return smprintf("n/a");

     }
 
     /* open wifi file */
     if (!(fp = fopen("/proc/net/wireless", "r"))) {
         fprintf(stderr, "Error opening wireless file.");
     }
 
     /* open wifi file */
     if (!(fp = fopen("/proc/net/wireless", "r"))) {
         fprintf(stderr, "Error opening wireless file.");

-        exit(1);
+        return smprintf("n/a");

     }
 
     /* extract the signal strength */
     }
 
     /* extract the signal strength */


@@ -316,44 +336,35 @@ get_wifi_signal()
 int
 main()
 {
 int
 main()
 {

-    char status[1024];
-    char *battery = NULL;
-    char *cpu_temperature = NULL;
-    char *cpu_usage = NULL;
-    char *datetime = NULL;
-    char *ram_usage = NULL;
-    char *volume = NULL;
-    char *wifi_signal = NULL;
-
-    /* open display */
+    char status_string[1024];
+    struct arg argument;
+
+    /* try to open display */

     if (!(dpy = XOpenDisplay(0x0))) {
         fprintf(stderr, "Cannot open display!\n");
         exit(1);
     }
 
     if (!(dpy = XOpenDisplay(0x0))) {
         fprintf(stderr, "Cannot open display!\n");
         exit(1);
     }
 

-    /* return status every second */
+    /* return status every interval */

     for (;;) {
     for (;;) {

-        /* assign the values */
-        battery = get_battery();
-        cpu_temperature = get_cpu_temperature();
-        cpu_usage = get_cpu_usage();
-        datetime = get_datetime();
-        ram_usage = get_ram_usage();
-        volume = get_volume();
-        wifi_signal = get_wifi_signal();
-
-        /* return the status */
-        sprintf(status, FORMATSTRING, ARGUMENTS);
-        setstatus(status);
-
-        /* free the values */
-        free(battery);
-        free(cpu_temperature);
-        free(cpu_usage);
-        free(datetime);
-        free(ram_usage);
-        free(volume);
-        free(wifi_signal);
+        /* clear the string */
+        memset(status_string, 0, sizeof(status_string));
+
+        /* generate status_string */
+        for (size_t i = 0; i < sizeof(args) / sizeof(args[0]); ++i) {
+            argument = args[i];
+            char *res = argument.func(argument.args);
+            char *element = smprintf(argument.format, res);
+            strcat(status_string, element);
+            free(res);
+            free(element);
+        }
+
+        /* return the statusbar */
+        setstatus(status_string);
+
+        /* wait, "update_interval - 1" because of get_cpu_usage() which uses 1 second */
+        sleep(update_interval -1);

     }
 
     /* close display */
     }
 
     /* close display */