run_command: strlen() will not function if string is not null terminated

[slstatus.git] / slstatus.c

diff --git a/slstatus.c b/slstatus.c
index 06c1e77..4432e18 100644 (file)
--- a/slstatus.c
+++ b/slstatus.c
@@ -69,7 +69,7 @@ static char *vol_perc(const char *card);
 static char *wifi_perc(const char *iface);
 static char *wifi_essid(const char *iface);
 static void sighandler(const int signo);
-static void usage(int);
+static void usage(const int eval);
 
 char *argv0;
 char concat[];
@@ -426,7 +426,7 @@ run_command(const char *cmd)
        }
        fgets(buf, sizeof(buf), fp);
        pclose(fp);
-       buf[strlen(buf)] = '\0';
+       buf[sizeof(buf)] = '\0';
 
        if ((nlptr = strstr(buf, "\n")) != NULL) {
                nlptr[0] = '\0';
@@ -746,7 +746,7 @@ sighandler(const int signo)
 }
 
 static void
-usage(int eval)
+usage(const int eval)
 {
        fprintf(stderr, "usage: %s [-d] [-o] [-v] [-h]\n", argv0);
        exit(eval);