uptime: Improve typing and sort headers

[slstatus.git] / components / run_command.c

diff --git a/components/run_command.c b/components/run_command.c
index 4a63896..e00b478 100644 (file)
--- a/components/run_command.c
+++ b/components/run_command.c
@@ -10,17 +10,21 @@ run_command(const char *cmd)
        char *p;
        FILE *fp;
 
-       fp = popen(cmd, "r");
-       if (fp == NULL) {
-               fprintf(stderr, "Failed to get command output for %s", cmd);
+       if (!(fp = popen(cmd, "r"))) {
+               warn("popen '%s':", cmd);
                return NULL;
        }
        p = fgets(buf, sizeof(buf) - 1, fp);
-       pclose(fp);
-       if (!p)
+       if (pclose(fp) < 0) {
+               warn("pclose '%s':", cmd);
                return NULL;
-       if ((p = strrchr(buf, '\n')) != NULL)
+       }
+       if (!p) {
+               return NULL;
+       }
+       if ((p = strrchr(buf, '\n'))) {
                p[0] = '\0';
+       }
 
        return buf[0] ? buf : NULL;
 }