Audit slstatus.c

[slstatus.git] / slstatus.c

diff --git a/slstatus.c b/slstatus.c
index b4eb761..7ff323f 100644 (file)
--- a/slstatus.c
+++ b/slstatus.c
@@ -1,7 +1,5 @@
 /* See LICENSE file for copyright and license details. */
-#include <err.h>
 #include <errno.h>
-#include <locale.h>
 #include <signal.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -10,6 +8,7 @@
 #include <X11/Xlib.h>
 
 #include "arg.h"
+#include "slstatus.h"
 #include "util.h"
 
 struct arg {
@@ -19,15 +18,17 @@ struct arg {
 };
 
 char *argv0;
-static unsigned short int done;
+char buf[1024];
+static int done;
 static Display *dpy;
 
-#include "slstatus.h"
 #include "config.h"
 
 static void
 terminate(const int signo)
 {
+       (void)signo;
+
        done = 1;
 }
 
@@ -52,9 +53,11 @@ main(int argc, char *argv[])
        struct sigaction act;
        struct timespec start, current, diff, intspec, wait;
        size_t i, len;
-       int sflag = 0;
+       int sflag, ret;
        char status[MAXLEN];
+       const char *res;
 
+       sflag = 0;
        ARGBEGIN {
                case 's':
                        sflag = 1;
@@ -67,40 +70,60 @@ main(int argc, char *argv[])
                usage();
        }
 
-       setlocale(LC_ALL, "");
-
        memset(&act, 0, sizeof(act));
        act.sa_handler = terminate;
        sigaction(SIGINT,  &act, NULL);
        sigaction(SIGTERM, &act, NULL);
 
+       if (sflag) {
+               setbuf(stdout, NULL);
+       }
+
        if (!sflag && !(dpy = XOpenDisplay(NULL))) {
-               fprintf(stderr, "slstatus: cannot open display");
+               fprintf(stderr, "XOpenDisplay: Failed to open display\n");
                return 1;
        }
 
        while (!done) {
-               clock_gettime(CLOCK_MONOTONIC, &start);
+               if (clock_gettime(CLOCK_MONOTONIC, &start) < 0) {
+                       fprintf(stderr, "clock_gettime: %s\n", strerror(errno));
+                       return 1;
+               }
 
                status[0] = '\0';
                for (i = len = 0; i < LEN(args); i++) {
-                       len += snprintf(status + len, sizeof(status) - len,
-                                       args[i].fmt, args[i].func(args[i].args));
-
-                       if (len >= sizeof(status)) {
-                               status[sizeof(status) - 1] = '\0';
+                       if (!(res = args[i].func(args[i].args))) {
+                               res = unknown_str;
+                       }
+                       if ((ret = snprintf(status + len, sizeof(status) - len,
+                                           args[i].fmt, res)) < 0) {
+                               fprintf(stderr, "snprintf: %s\n",
+                                       strerror(errno));
+                               break;
+                       } else if ((size_t)ret >= sizeof(status) - len) {
+                               fprintf(stderr, "snprintf: Output truncated\n");
+                               break;
                        }
+                       len += ret;
                }
 
                if (sflag) {
                        printf("%s\n", status);
                } else {
-                       XStoreName(dpy, DefaultRootWindow(dpy), status);
-                       XSync(dpy, False);
+                       if (XStoreName(dpy, DefaultRootWindow(dpy), status) < 0) {
+                               fprintf(stderr,
+                                       "XStoreName: Allocation failed\n");
+                               return 1;
+                       }
+                       XFlush(dpy);
                }
 
                if (!done) {
-                       clock_gettime(CLOCK_MONOTONIC, &current);
+                       if (clock_gettime(CLOCK_MONOTONIC, &current) < 0) {
+                               fprintf(stderr, "clock_gettime: %s\n",
+                                       strerror(errno));
+                               return 1;
+                       }
                        difftimespec(&diff, &current, &start);
 
                        intspec.tv_sec = interval / 1000;
@@ -108,14 +131,23 @@ main(int argc, char *argv[])
                        difftimespec(&wait, &intspec, &diff);
 
                        if (wait.tv_sec >= 0) {
-                               nanosleep(&wait, NULL);
+                               if (nanosleep(&wait, NULL) < 0 &&
+                                   errno != EINTR) {
+                                       fprintf(stderr, "nanosleep: %s\n",
+                                               strerror(errno));
+                                       return 1;
+                               }
                        }
                }
        }
 
        if (!sflag) {
                XStoreName(dpy, DefaultRootWindow(dpy), NULL);
-               XCloseDisplay(dpy);
+               if (XCloseDisplay(dpy) < 0) {
+                       fprintf(stderr,
+                               "XCloseDisplay: Failed to close display\n");
+                       return 1;
+               }
        }
 
        return 0;