Consistent paramter naming for components

[slstatus.git] / slstatus.c

diff --git a/slstatus.c b/slstatus.c
index e8d367b..e6aa90b 100644 (file)
--- a/slstatus.c
+++ b/slstatus.c
@@ -1,5 +1,5 @@
 /* See LICENSE file for copyright and license details. */
-#include <locale.h>
+#include <errno.h>
 #include <signal.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -17,7 +17,6 @@ struct arg {
        const char *args;
 };
 
-char *argv0;
 char buf[1024];
 static int done;
 static Display *dpy;
@@ -37,14 +36,13 @@ difftimespec(struct timespec *res, struct timespec *a, struct timespec *b)
 {
        res->tv_sec = a->tv_sec - b->tv_sec - (a->tv_nsec < b->tv_nsec);
        res->tv_nsec = a->tv_nsec - b->tv_nsec +
-                      (a->tv_nsec < b->tv_nsec) * 1000000000;
+                      (a->tv_nsec < b->tv_nsec) * 1E9;
 }
 
 static void
 usage(void)
 {
-       fprintf(stderr, "usage: %s [-s]\n", argv0);
-       exit(1);
+       die("usage: %s [-s]", argv0);
 }
 
 int
@@ -53,8 +51,9 @@ main(int argc, char *argv[])
        struct sigaction act;
        struct timespec start, current, diff, intspec, wait;
        size_t i, len;
-       int sflag;
+       int sflag, ret;
        char status[MAXLEN];
+       const char *res;
 
        sflag = 0;
        ARGBEGIN {
@@ -69,58 +68,68 @@ main(int argc, char *argv[])
                usage();
        }
 
-       setlocale(LC_ALL, "");
-
        memset(&act, 0, sizeof(act));
        act.sa_handler = terminate;
        sigaction(SIGINT,  &act, NULL);
        sigaction(SIGTERM, &act, NULL);
 
        if (!sflag && !(dpy = XOpenDisplay(NULL))) {
-               fprintf(stderr, "Cannot open display");
-               return 1;
+               die("XOpenDisplay: Failed to open display");
        }
 
        while (!done) {
-               clock_gettime(CLOCK_MONOTONIC, &start);
+               if (clock_gettime(CLOCK_MONOTONIC, &start) < 0) {
+                       die("clock_gettime:");
+               }
 
                status[0] = '\0';
                for (i = len = 0; i < LEN(args); i++) {
-                       const char * res = args[i].func(args[i].args);
-                       res = (res == NULL) ? unknown_str : res;
-                       len += snprintf(status + len, sizeof(status) - len,
-                                       args[i].fmt, res);
-
-                       if (len >= sizeof(status)) {
-                               status[sizeof(status) - 1] = '\0';
+                       if (!(res = args[i].func(args[i].args))) {
+                               res = unknown_str;
+                       }
+                       if ((ret = esnprintf(status + len, sizeof(status) - len,
+                                           args[i].fmt, res)) < 0) {
+                               break;
                        }
+                       len += ret;
                }
 
                if (sflag) {
-                       printf("%s\n", status);
+                       puts(status);
                        fflush(stdout);
+                       if (ferror(stdout))
+                               die("puts:");
                } else {
-                       XStoreName(dpy, DefaultRootWindow(dpy), status);
-                       XSync(dpy, False);
+                       if (XStoreName(dpy, DefaultRootWindow(dpy), status) < 0) {
+                               die("XStoreName: Allocation failed");
+                       }
+                       XFlush(dpy);
                }
 
                if (!done) {
-                       clock_gettime(CLOCK_MONOTONIC, &current);
+                       if (clock_gettime(CLOCK_MONOTONIC, &current) < 0) {
+                               die("clock_gettime:");
+                       }
                        difftimespec(&diff, &current, &start);
 
                        intspec.tv_sec = interval / 1000;
-                       intspec.tv_nsec = (interval % 1000) * 1000000;
+                       intspec.tv_nsec = (interval % 1000) * 1E6;
                        difftimespec(&wait, &intspec, &diff);
 
                        if (wait.tv_sec >= 0) {
-                               nanosleep(&wait, NULL);
+                               if (nanosleep(&wait, NULL) < 0 &&
+                                   errno != EINTR) {
+                                       die("nanosleep:");
+                               }
                        }
                }
        }
 
        if (!sflag) {
                XStoreName(dpy, DefaultRootWindow(dpy), NULL);
-               XCloseDisplay(dpy);
+               if (XCloseDisplay(dpy) < 0) {
+                       die("XCloseDisplay: Failed to close display");
+               }
        }
 
        return 0;