Xinqi Bao's Git

Fix coding style
[slstatus.git] / components / uptime.c
index c5e28ee..981f3cd 100644 (file)
@@ -1,45 +1,61 @@
 /* See LICENSE file for copyright and license details. */
 #include <stdio.h>
-#ifdef __linux__
-#include <sys/sysinfo.h>
-#elif __OpenBSD__
-#include <sys/sysctl.h>
-#include <sys/time.h>
-#endif
 
 #include "../util.h"
 
 const char *
-uptime(void)
+format(int uptime)
 {
-       int h;
-       int m;
-       int uptime = 0;
-#ifdef __linux__
-       struct sysinfo info;
+       int h, m;
+
+       h = uptime / 3600;
+       m = (uptime - h * 3600) / 60;
+
+       return bprintf("%dh %dm", h, m);
+}
+
+#if defined(__linux__)
+       #include <sys/sysinfo.h>
+
+       const char *
+       uptime(void)
+       {
+               int uptime;
+               struct sysinfo info;
 
-       sysinfo(&info);
-       uptime = info.uptime;
-#elif __OpenBSD__
-       int mib[2];
-       size_t size;
-       time_t now;
-       struct timeval boottime;
+               sysinfo(&info);
+               uptime = info.uptime;
 
-       time(&now);
+               return format(uptime);
+       }
+#elif defined(__OpenBSD__)
+       #include <errno.h>
+       #include <string.h>
+       #include <sys/sysctl.h>
+       #include <sys/time.h>
 
-       mib[0] = CTL_KERN;
-       mib[1] = KERN_BOOTTIME;
+       const char *
+       uptime(void)
+       {
+               int mib[2], uptime;
+               size_t size;
+               time_t now;
+               struct timeval boottime;
 
-       size = sizeof(boottime);
+               time(&now);
+
+               mib[0] = CTL_KERN;
+               mib[1] = KERN_BOOTTIME;
+
+               size = sizeof(boottime);
+
+               if (sysctl(mib, 2, &boottime, &size, NULL, 0) < 0) {
+                       fprintf(stderr, "sysctl 'KERN_BOOTTIME': %s\n", strerror(errno));
+                       return NULL;
+               }
 
-       if (sysctl(mib, 2, &boottime, &size, NULL, 0) != -1)
                uptime = now - boottime.tv_sec;
-       else
-               return NULL;
-#endif
-       h = uptime / 3600;
-       m = (uptime - h * 3600) / 60;
 
-       return bprintf("%dh %dm", h, m);
-}
+               return format(uptime);
+       }
+#endif