X-Git-Url: https://git.xinqibao.xyz/slstatus.git/blobdiff_plain/3bfa5fe60d69e800dbe4364cf5122af21d00fd4c..a1c962f8a385dc6da5ea84fe0363a3f71f342d06:/slstatus.c?ds=inline

diff --git a/slstatus.c b/slstatus.c
index 627d270..6e86092 100644
--- a/slstatus.c
+++ b/slstatus.c
@@ -63,6 +63,7 @@ static char *vol_perc(const char *);
 static char *wifi_perc(const char *);
 static char *wifi_essid(const char *);
 
+static unsigned short int delay;
 static Display *dpy;
 
 #include "config.h"
@@ -139,7 +140,8 @@ cpu_perc(void)
 	fscanf(fp, "%*s %Lf %Lf %Lf %Lf", &a[0], &a[1], &a[2], &a[3]);
 	fclose(fp);
 
-	sleep(1);
+	delay = (UPDATE_INTERVAL - (UPDATE_INTERVAL - 1));
+	sleep(delay);
 
 	fp = fopen("/proc/stat","r");
 	if (fp == NULL) {
@@ -277,7 +279,6 @@ ip(const char *interface)
 		return smprintf(UNKNOWN_STR);
 	}
 
-	/* get the ip address */
 	for (ifa = ifaddr; ifa != NULL; ifa = ifa->ifa_next) {
 		if (ifa->ifa_addr == NULL)
 			continue;
@@ -294,7 +295,6 @@ ip(const char *interface)
 		}
 	}
 
-	/* free the address */
 	freeifaddrs(ifaddr);
 
 	return smprintf(UNKNOWN_STR);
@@ -397,7 +397,7 @@ run_command(const char* command)
 {
 	int good;
 	FILE *fp = popen(command, "r");
-	char buffer[64];
+	char buffer[64] = "";
 
 	if (fp == NULL) {
 		warn("Could not get command output for: %s", command);
@@ -455,11 +455,12 @@ username(void)
 	uid_t uid = geteuid();
 	struct passwd *pw = getpwuid(uid);
 
-	if (pw == NULL)
-		return smprintf("%s", pw->pw_name);
+	if (pw == NULL) {
+		warn("Could not get username");
+		return smprintf(UNKNOWN_STR);
+	}
 
-	warn("Could not get username");
-	return smprintf(UNKNOWN_STR);
+	return smprintf("%s", pw->pw_name);
 }
 
 static char *
@@ -471,24 +472,24 @@ uid(void)
 
 static char * 
 vol_perc(const char *snd_card)
-{ /* thanks to botika for this function */
+{ /* FIX THIS SHIT! */
 	long int vol, max, min;
 	snd_mixer_t *handle;
 	snd_mixer_elem_t *elem;
 	snd_mixer_selem_id_t *s_elem;
 
 	snd_mixer_open(&handle, 0);
-	snd_mixer_attach(handle, "default");
+	snd_mixer_attach(handle, snd_card);
 	snd_mixer_selem_register(handle, NULL, NULL);
 	snd_mixer_load(handle);
 	snd_mixer_selem_id_malloc(&s_elem);
-	snd_mixer_selem_id_set_name(s_elem, snd_card);
+	snd_mixer_selem_id_set_name(s_elem, ALSA_CHANNEL);
 	elem = snd_mixer_find_selem(handle, s_elem);
 
 	if (elem == NULL) {
 		snd_mixer_selem_id_free(s_elem);
 		snd_mixer_close(handle);
-		perror("alsa error");
+		warn("error: ALSA");
 		return smprintf(UNKNOWN_STR);
 	}
 
@@ -499,7 +500,7 @@ vol_perc(const char *snd_card)
 	snd_mixer_selem_id_free(s_elem);
 	snd_mixer_close(handle);
 
-	return smprintf("%d", (vol * 100) / max);
+	return smprintf("%d", ((uint_fast16_t)(vol * 100) / max));
 }
 
 static char *
@@ -511,7 +512,7 @@ wifi_perc(const char *wificard)
 	char status[5];
 	FILE *fp;
 
-	ccat(3, "/sys/class/net", wificard, "/operstate");
+	ccat(3, "/sys/class/net/", wificard, "/operstate");
 
 	fp = fopen(concat, "r");
 
@@ -567,6 +568,8 @@ wifi_essid(const char *wificard)
 		return smprintf(UNKNOWN_STR);
 	}
 
+	close(sockfd);
+
 	if (strcmp((char *)wreq.u.essid.pointer, "") == 0)
 		return smprintf(UNKNOWN_STR);
 	else
@@ -584,7 +587,7 @@ main(void)
 	dpy = XOpenDisplay(NULL);
 
 	for (;;) {
-		memset(status_string, 0, sizeof(status_string));
+		status_string[0] = '\0';
 		for (i = 0; i < sizeof(args) / sizeof(args[0]); ++i) {
 			argument = args[i];
 			if (argument.args == NULL)
@@ -602,7 +605,14 @@ main(void)
 		}
 		XStoreName(dpy, DefaultRootWindow(dpy), status_string);
 		XSync(dpy, False);
+		/*
+		 * subtract delay time spend in function
+		 * calls from the actual global delay time
+		 */
+		sleep(UPDATE_INTERVAL - delay);
+		delay = 0;
 	}
+
 	XCloseDisplay(dpy);
 
 	return 0;