X-Git-Url: https://git.xinqibao.xyz/slstatus.git/blobdiff_plain/7246dc4381c6c95454672a5c1aff65a02d6d3747..951ea4e304cf23f8464a4b6896cfcf4035920249:/components/volume.c?ds=sidebyside

diff --git a/components/volume.c b/components/volume.c
index f5aa18d..0bfbe08 100644
--- a/components/volume.c
+++ b/components/volume.c
@@ -1,10 +1,14 @@
 /* See LICENSE file for copyright and license details. */
-#include <err.h>
+#include <errno.h>
 #include <fcntl.h>
-#include <sys/soundcard.h>
-#include <sys/ioctl.h>
 #include <stdio.h>
 #include <string.h>
+#if defined(__OpenBSD__)
+	#include <soundcard.h>
+#else
+	#include <sys/soundcard.h>
+#endif
+#include <sys/ioctl.h>
 #include <unistd.h>
 
 #include "../util.h"
@@ -12,25 +16,24 @@
 const char *
 vol_perc(const char *card)
 {
-	unsigned int i;
+	size_t i;
 	int v, afd, devmask;
 	char *vnames[] = SOUND_DEVICE_NAMES;
 
-	afd = open(card, O_RDONLY | O_NONBLOCK);
-	if (afd == -1) {
-		warn("Cannot open %s", card);
+	if ((afd = open(card, O_RDONLY | O_NONBLOCK)) < 0) {
+		warn("open '%s':", card);
 		return NULL;
 	}
 
-	if (ioctl(afd, SOUND_MIXER_READ_DEVMASK, &devmask) == -1) {
-		warn("Cannot get volume for %s", card);
+	if (ioctl(afd, (int)SOUND_MIXER_READ_DEVMASK, &devmask) < 0) {
+		warn("ioctl 'SOUND_MIXER_READ_DEVMASK':");
 		close(afd);
 		return NULL;
 	}
 	for (i = 0; i < LEN(vnames); i++) {
 		if (devmask & (1 << i) && !strcmp("vol", vnames[i])) {
-			if (ioctl(afd, MIXER_READ(i), &v) == -1) {
-				warn("vol_perc: ioctl");
+			if (ioctl(afd, MIXER_READ(i), &v) < 0) {
+				warn("ioctl 'MIXER_READ(%ld)':", i);
 				close(afd);
 				return NULL;
 			}
@@ -39,5 +42,5 @@ vol_perc(const char *card)
 
 	close(afd);
 
-	return bprintf("%d", v & 0xff);
+	return bprintf("%d%%", v & 0xff);
 }