X-Git-Url: https://git.xinqibao.xyz/slstatus.git/blobdiff_plain/faa52bdcc0221de2d8fae950e409a8ac5e05bfcd..103945e7bb8d3a4198cf175b8f6be09fe53ab9e1:/components/run_command.c diff --git a/components/run_command.c b/components/run_command.c index 2041ae4..7ae1b69 100644 --- a/components/run_command.c +++ b/components/run_command.c @@ -11,17 +11,21 @@ run_command(const char *cmd) char *p; FILE *fp; - fp = popen(cmd, "r"); - if (fp == NULL) { - fprintf(stderr, "popen '%s': %s\n", cmd, strerror(errno)); + if (!(fp = popen(cmd, "r"))) { + warn("popen '%s':", cmd); return NULL; } p = fgets(buf, sizeof(buf) - 1, fp); - pclose(fp); - if (!p) + if (pclose(fp) < 0) { + warn("pclose '%s':", cmd); return NULL; - if ((p = strrchr(buf, '\n')) != NULL) + } + if (!p) { + return NULL; + } + if ((p = strrchr(buf, '\n'))) { p[0] = '\0'; + } return buf[0] ? buf : NULL; }