Xinqi Bao's Git

keyboard_indicators: fix segfault when -s is specified
authorAli H. Fardan <[email protected]>
Sat, 12 Aug 2017 04:01:13 +0000 (07:01 +0300)
committerAaron Marcher <[email protected]>
Sat, 12 Aug 2017 10:50:11 +0000 (12:50 +0200)
slstatus.c

index 47bd4c9..aa05cd1 100644 (file)
@@ -380,9 +380,15 @@ kernel_release(void)
 static const char *
 keyboard_indicators(void)
 {
+       Display *dpy = XOpenDisplay(NULL);
        XKeyboardState state;
 
+       if (dpy == NULL) {
+               warnx("XOpenDisplay failed");
+               return UNKNOWN_STR;
+       }
        XGetKeyboardControl(dpy, &state);
+       XCloseDisplay(dpy);
 
        switch (state.led_mask) {
                case 1: