Xinqi Bao's Git

On success, fgets always terminates the result.
authorTobias Stoeckmann <[email protected]>
Tue, 4 Apr 2017 19:27:31 +0000 (21:27 +0200)
committerTobias Stoeckmann <[email protected]>
Tue, 4 Apr 2017 19:27:31 +0000 (21:27 +0200)
If fgets succeeds, then the resulting char array is always
terminated by a '\0'. No need to keep extra space, therefore
sizeof(buf) is the correct argument.

Signed-off-by: Tobias Stoeckmann <[email protected]>
slstatus.c

index 6deb68c..ada6441 100644 (file)
@@ -447,7 +447,7 @@ run_command(const char *cmd)
                warn("Failed to get command output for %s", cmd);
                return smprintf("%s", UNKNOWN_STR);
        }
-       fgets(buf, sizeof(buf) - 1, fp);
+       fgets(buf, sizeof(buf), fp);
        pclose(fp);
        buf[sizeof(buf) - 1] = '\0';