Xinqi Bao's Git
projects
/
st.git
/ blobdiff
summary
|
log
|
commit
|
diff
|
tree
raw
|
inline
| side by side
clipcopy: no need to check for free(NULL), set to NULL after free
[st.git]
/
x.c
diff --git
a/x.c
b/x.c
index
970d6dd
..
12bc86b
100644
(file)
--- a/
x.c
+++ b/
x.c
@@
-1,15
+1,15
@@
/* See LICENSE for license details. */
#include <errno.h>
/* See LICENSE for license details. */
#include <errno.h>
+#include <math.h>
+#include <limits.h>
#include <locale.h>
#include <signal.h>
#include <locale.h>
#include <signal.h>
-#include <stdint.h>
#include <sys/select.h>
#include <time.h>
#include <unistd.h>
#include <libgen.h>
#include <X11/Xatom.h>
#include <X11/Xlib.h>
#include <sys/select.h>
#include <time.h>
#include <unistd.h>
#include <libgen.h>
#include <X11/Xatom.h>
#include <X11/Xlib.h>
-#include <X11/Xutil.h>
#include <X11/cursorfont.h>
#include <X11/keysym.h>
#include <X11/Xft/Xft.h>
#include <X11/cursorfont.h>
#include <X11/keysym.h>
#include <X11/Xft/Xft.h>
@@
-75,6
+75,15
@@
typedef XftColor Color;
typedef XftGlyphFontSpec GlyphFontSpec;
/* Purely graphic info */
typedef XftGlyphFontSpec GlyphFontSpec;
/* Purely graphic info */
+typedef struct {
+ int tw, th; /* tty width and height */
+ int w, h; /* window width and height */
+ int ch; /* char height */
+ int cw; /* char width */
+ int mode; /* window state/mode flags */
+ int cursor; /* cursor style */
+} TermWindow;
+
typedef struct {
Display *dpy;
Colormap cmap;
typedef struct {
Display *dpy;
Colormap cmap;
@@
-133,14
+142,16
@@
static int xgeommasktogravity(int);
static void xinit(int, int);
static void cresize(int, int);
static void xresize(int, int);
static void xinit(int, int);
static void cresize(int, int);
static void xresize(int, int);
+static void xhints(void);
+static int xloadcolor(int, const char *, Color *);
static int xloadfont(Font *, FcPattern *);
static void xloadfonts(char *, double);
static void xunloadfont(Font *);
static void xunloadfonts(void);
static void xsetenv(void);
static void xseturgency(int);
static int xloadfont(Font *, FcPattern *);
static void xloadfonts(char *, double);
static void xunloadfont(Font *);
static void xunloadfonts(void);
static void xsetenv(void);
static void xseturgency(int);
-static int
x2col(int
);
-static int
y2row(int
);
+static int
evcol(XEvent *
);
+static int
evrow(XEvent *
);
static void expose(XEvent *);
static void visibility(XEvent *);
static void expose(XEvent *);
static void visibility(XEvent *);
@@
-234,8
+245,8
@@
clipcopy(const Arg *dummy)
{
Atom clipboard;
{
Atom clipboard;
- if (xsel.clipboard != NULL)
-
free(xsel.clipboard)
;
+ free(xsel.clipboard);
+
xsel.clipboard = NULL
;
if (xsel.primary != NULL) {
xsel.clipboard = xstrdup(xsel.primary);
if (xsel.primary != NULL) {
xsel.clipboard = xstrdup(xsel.primary);
@@
-298,17
+309,17
@@
zoomreset(const Arg *arg)
}
int
}
int
-
x2col(int x
)
+
evcol(XEvent *e
)
{
{
-
x -=
borderpx;
+
int x = e->xbutton.x -
borderpx;
LIMIT(x, 0, win.tw - 1);
return x / win.cw;
}
int
LIMIT(x, 0, win.tw - 1);
return x / win.cw;
}
int
-
y2row(int y
)
+
evrow(XEvent *e
)
{
{
-
y -=
borderpx;
+
int y = e->xbutton.y -
borderpx;
LIMIT(y, 0, win.th - 1);
return y / win.ch;
}
LIMIT(y, 0, win.th - 1);
return y / win.ch;
}
@@
-325,7
+336,7
@@
mousesel(XEvent *e, int done)
break;
}
}
break;
}
}
- selextend(
x2col(e->xbutton.x), y2row(e->xbutton.y
), seltype, done);
+ selextend(
evcol(e), evrow(e
), seltype, done);
if (done)
setsel(getsel(), e->xbutton.time);
}
if (done)
setsel(getsel(), e->xbutton.time);
}
@@
-333,9
+344,8
@@
mousesel(XEvent *e, int done)
void
mousereport(XEvent *e)
{
void
mousereport(XEvent *e)
{
- int x = x2col(e->xbutton.x), y = y2row(e->xbutton.y),
- button = e->xbutton.button, state = e->xbutton.state,
- len;
+ int len, x = evcol(e), y = evrow(e),
+ button = e->xbutton.button, state = e->xbutton.state;
char buf[40];
static int ox, oy;
char buf[40];
static int ox, oy;
@@
-430,7
+440,7
@@
bpress(XEvent *e)
xsel.tclick2 = xsel.tclick1;
xsel.tclick1 = now;
xsel.tclick2 = xsel.tclick1;
xsel.tclick1 = now;
- selstart(
x2col(e->xbutton.x), y2row(e->xbutton.y
), snap);
+ selstart(
evcol(e), evrow(e
), snap);
}
}
}
}
@@
-454,18
+464,16
@@
selnotify(XEvent *e)
ulong nitems, ofs, rem;
int format;
uchar *data, *last, *repl;
ulong nitems, ofs, rem;
int format;
uchar *data, *last, *repl;
- Atom type, incratom, property;
+ Atom type, incratom, property
= None
;
incratom = XInternAtom(xw.dpy, "INCR", 0);
ofs = 0;
incratom = XInternAtom(xw.dpy, "INCR", 0);
ofs = 0;
- if (e->type == SelectionNotify)
{
+ if (e->type == SelectionNotify)
property = e->xselection.property;
property = e->xselection.property;
- } else if(e->type == PropertyNotify) {
+ else if (e->type == PropertyNotify)
property = e->xproperty.atom;
property = e->xproperty.atom;
- } else {
- return;
- }
+
if (property == None)
return;
if (property == None)
return;
@@
-615,7
+623,7
@@
setsel(char *str, Time t)
XSetSelectionOwner(xw.dpy, XA_PRIMARY, xw.win, t);
if (XGetSelectionOwner(xw.dpy, XA_PRIMARY) != xw.win)
XSetSelectionOwner(xw.dpy, XA_PRIMARY, xw.win, t);
if (XGetSelectionOwner(xw.dpy, XA_PRIMARY) != xw.win)
- selclear
_(NULL
);
+ selclear
(
);
}
void
}
void
@@
-773,7
+781,7
@@
xhints(void)
XClassHint class = {opt_name ? opt_name : termname,
opt_class ? opt_class : termname};
XWMHints wm = {.flags = InputHint, .input = 1};
XClassHint class = {opt_name ? opt_name : termname,
opt_class ? opt_class : termname};
XWMHints wm = {.flags = InputHint, .input = 1};
- XSizeHints *sizeh
= NULL
;
+ XSizeHints *sizeh;
sizeh = XAllocSizeHints();
sizeh = XAllocSizeHints();
@@
-894,7
+902,6
@@
xloadfonts(char *fontstr, double fontsize)
{
FcPattern *pattern;
double fontval;
{
FcPattern *pattern;
double fontval;
- float ceilf(float);
if (fontstr[0] == '-') {
pattern = XftXlfdParse(fontstr, False, False);
if (fontstr[0] == '-') {
pattern = XftXlfdParse(fontstr, False, False);
@@
-1397,12
+1404,13
@@
xdrawcursor(int cx, int cy, Glyph g, int ox, int oy, Glyph og)
og.mode ^= ATTR_REVERSE;
xdrawglyph(og, ox, oy);
og.mode ^= ATTR_REVERSE;
xdrawglyph(og, ox, oy);
+ if (IS_SET(MODE_HIDE))
+ return;
+
/*
* Select the right color for the right mode.
*/
g.mode &= ATTR_BOLD|ATTR_ITALIC|ATTR_UNDERLINE|ATTR_STRUCK|ATTR_WIDE;
/*
* Select the right color for the right mode.
*/
g.mode &= ATTR_BOLD|ATTR_ITALIC|ATTR_UNDERLINE|ATTR_STRUCK|ATTR_WIDE;
- g.fg = defaultbg;
- g.bg = defaultcs;
if (IS_SET(MODE_REVERSE)) {
g.mode |= ATTR_REVERSE;
if (IS_SET(MODE_REVERSE)) {
g.mode |= ATTR_REVERSE;
@@
-1416,22
+1424,20
@@
xdrawcursor(int cx, int cy, Glyph g, int ox, int oy, Glyph og)
}
} else {
if (selected(cx, cy)) {
}
} else {
if (selected(cx, cy)) {
- drawcol = dc.col[defaultrcs];
g.fg = defaultfg;
g.bg = defaultrcs;
} else {
g.fg = defaultfg;
g.bg = defaultrcs;
} else {
- drawcol = dc.col[defaultcs];
+ g.fg = defaultbg;
+ g.bg = defaultcs;
}
}
+ drawcol = dc.col[g.bg];
}
}
- if (IS_SET(MODE_HIDE))
- return;
-
/* draw the new one */
if (IS_SET(MODE_FOCUSED)) {
switch (win.cursor) {
/* draw the new one */
if (IS_SET(MODE_FOCUSED)) {
switch (win.cursor) {
- case 7: /* st extension: snowman */
-
utf8decode("☃", &g.u, UTF_SIZ)
;
+ case 7: /* st extension: snowman
(U+2603)
*/
+
g.u = 0x2603
;
case 0: /* Blinking Block */
case 1: /* Blinking Block (Default) */
case 2: /* Steady Block */
case 0: /* Blinking Block */
case 1: /* Blinking Block (Default) */
case 2: /* Steady Block */
@@
-1486,7
+1492,7
@@
void
xsettitle(char *p)
{
XTextProperty prop;
xsettitle(char *p)
{
XTextProperty prop;
- DEFAULT(p,
"st"
);
+ DEFAULT(p,
opt_title
);
Xutf8TextListToTextProperty(xw.dpy, &p, 1, XUTF8StringStyle,
&prop);
Xutf8TextListToTextProperty(xw.dpy, &p, 1, XUTF8StringStyle,
&prop);
@@
-1923,12
+1929,12
@@
main(int argc, char *argv[])
} ARGEND;
run:
} ARGEND;
run:
- if (argc > 0) {
- /* eat all remaining arguments */
+ if (argc > 0) /* eat all remaining arguments */
opt_cmd = argv;
opt_cmd = argv;
- if (!opt_title && !opt_line)
- opt_title = basename(xstrdup(argv[0]));
- }
+
+ if (!opt_title)
+ opt_title = (opt_line || !opt_cmd) ? "st" : opt_cmd[0];
+
setlocale(LC_CTYPE, "");
XSetLocaleModifiers("");
cols = MAX(cols, 1);
setlocale(LC_CTYPE, "");
XSetLocaleModifiers("");
cols = MAX(cols, 1);